Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[redis] Authentication support added #497

Merged
merged 3 commits into from
Aug 13, 2018
Merged

[redis] Authentication support added #497

merged 3 commits into from
Aug 13, 2018

Conversation

makasim
Copy link
Member

@makasim makasim commented Aug 13, 2018

No description provided.

@makasim makasim merged commit f14bf35 into master Aug 13, 2018
@makasim makasim deleted the pr-350 branch August 13, 2018 11:19
@Toflar
Copy link
Contributor

Toflar commented Aug 17, 2018

Hey, not sure I'm on the right track here but I just wanted to use redis with a password and had the same issue as the others. Great we can now configure it directly! I was about to give this a try but it doesn't work with Predis because of the initCommands. You named the parameter pass which will cause Predis to execute SELECT before AUTH (see https://github.com/nrk/predis/blob/v1.1/src/Connection/Factory.php#L172) and then it doesn't work due to SELECT failed: NOAUTH Authentication required 😄

@makasim
Copy link
Member Author

makasim commented Aug 18, 2018

@Toflar could you please open a new issue, or better a PR that fixes it.

@Toflar
Copy link
Contributor

Toflar commented Aug 20, 2018

Done.

ASKozienko pushed a commit that referenced this pull request Nov 2, 2018
[redis] Authentication support added
@makasim makasim added this to the 0.9 milestone Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants