Skip to content

remove bc layer. #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 8, 2018
Merged

remove bc layer. #489

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fe1a1df
remove bc layer.
makasim Aug 7, 2018
8a92d91
fix queue consumer tests. (not all for now)
makasim Aug 7, 2018
9c8fb4a
fix queue consumer tests.
makasim Aug 7, 2018
7b9dcec
revert final
makasim Aug 7, 2018
f1274c4
add script to recreate mysql database before test run.
makasim Aug 7, 2018
22a1593
0.7@dev to 0.7.x-dev
makasim Aug 8, 2018
b72d012
fix deps.
makasim Aug 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix queue consumer tests.
  • Loading branch information
@makasim
makasim committed Aug 7, 2018
commit 9c8fb4ad933a0684b8952c468cfc09b911b17fec
6 changes: 3 additions & 3 deletions pkg/enqueue/Consumption/Context.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,17 +136,17 @@ public function setPsrProcessor(PsrProcessor $psrProcessor)
}

/**
* @return \Exception
* @return \Throwable
*/
public function getException()
{
return $this->exception;
}

/**
* @param \Exception $exception
* @param \Throwable $exception
*/
public function setException(\Exception $exception)
public function setException(\Throwable $exception)
{
$this->exception = $exception;
}
Expand Down
4 changes: 4 additions & 0 deletions pkg/enqueue/Consumption/QueueConsumer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,10 @@ public function consume(ExtensionInterface $runtimeExtension = null)

$this->idleTimeout && usleep($this->idleTimeout * 1000);
$this->extension->onIdle($context);

if ($context->isExecutionInterrupted()) {
throw new ConsumptionInterruptedException();
}
} catch (ConsumptionInterruptedException $e) {
$this->logger->info(sprintf('Consuming interrupted'));

Expand Down
Loading