Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved symfony/framework-bundle to require-dev #348

Merged
merged 1 commit into from
Jan 29, 2018
Merged

Moved symfony/framework-bundle to require-dev #348

merged 1 commit into from
Jan 29, 2018

Conversation

prisis
Copy link
Contributor

@prisis prisis commented Jan 29, 2018

just the tests needs symfony/framework-bundle

@makasim
Copy link
Member

makasim commented Jan 29, 2018

We still need symfony/dependency-injection as far as I can see

@prisis
Copy link
Contributor Author

prisis commented Jan 29, 2018

Where?
All symfony related classes are in the tests folder

@prisis
Copy link
Contributor Author

prisis commented Jan 29, 2018

And the symfony/framework-bundle requires symfony/dependency-injection: ^3.4.3|^4.0.3

@makasim
Copy link
Member

makasim commented Jan 29, 2018

@prisis
Copy link
Contributor Author

prisis commented Jan 29, 2018

But the pr is only for the job-queue/composer.json

@makasim makasim merged commit 6b5b7cd into php-enqueue:master Jan 29, 2018
@prisis prisis deleted the patch-1 branch January 29, 2018 12:23
@prisis
Copy link
Contributor Author

prisis commented Jan 29, 2018

Thank you :)

@makasim
Copy link
Member

makasim commented Jan 29, 2018

Thank you

ASKozienko pushed a commit that referenced this pull request Nov 2, 2018
Moved symfony/framework-bundle to require-dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants