Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
db82ab6
Add PHP 8.5 and Symfony 8 to CI
andrewmy Nov 29, 2025
d5afeff
Bump symfony versions in pkgs; test with ORM 3.6.x
andrewmy Nov 29, 2025
c6d4016
Replace the removed method
andrewmy Nov 29, 2025
147a5e3
Allow newer doctrine package versions
andrewmy Nov 29, 2025
17c7185
Fix function signature
andrewmy Nov 29, 2025
f4ab0d6
Work around the removal of Connection::connect()
andrewmy Nov 29, 2025
b9e5750
Juggle connect()/getServerVersion()
andrewmy Nov 29, 2025
7ff8cb8
Fix the method detection
andrewmy Nov 29, 2025
65c7385
Fix the method visibility check
andrewmy Nov 29, 2025
09bbbd6
Fix CS
andrewmy Nov 29, 2025
5d49067
Fix more signatures
andrewmy Nov 29, 2025
3055292
Fix more signatures
andrewmy Nov 29, 2025
40de666
Don't mock resetter impl
andrewmy Nov 29, 2025
7d924f3
Fix CS
andrewmy Nov 29, 2025
0bb43bb
Fix the pdo driver indication; one more place with connect()
andrewmy Nov 29, 2025
4316bf4
Better pdo driver string?
andrewmy Nov 29, 2025
a11a200
Drop PHP 8.5 from CI
andrewmy Dec 1, 2025
6a482c4
Drop SF5 from tests
andrewmy Dec 1, 2025
8132e71
DBAL 4 compatibility
andrewmy Dec 1, 2025
fff2dc9
ORM 3 compat
andrewmy Dec 1, 2025
1bdad59
Simplify DSN stuff again
andrewmy Dec 2, 2025
440c840
Fix DSN tests
andrewmy Dec 19, 2025
12bd6c6
Remove PHP 8.1 from CI, it's EOL on 2025.12.31. Also clean up 8.5 for…
andrewmy Dec 19, 2025
9c8669b
aws-sdk dropped old guzzle/psr7 and older aws versions no longer inst…
andrewmy Dec 19, 2025
d811f99
Fix CS job
andrewmy Dec 19, 2025
d804a1d
derp
andrewmy Dec 19, 2025
e2ff7e1
Fix deprecation
andrewmy Dec 19, 2025
ee38f85
Fix DSN parsing
andrewmy Dec 19, 2025
667fe84
Fix CS
andrewmy Dec 19, 2025
217544d
Fix compat
andrewmy Dec 19, 2025
b8e283f
CS derp
andrewmy Dec 19, 2025
e017c62
Restore doctrine/orm requirement, add 3
andrewmy Dec 20, 2025
61ca928
Bump doctrine orm and persistence lowest
andrewmy Dec 20, 2025
36ffefc
Fix DBAL 3 compat
andrewmy Dec 20, 2025
1055259
derpito
andrewmy Dec 20, 2025
5c3d743
Bump doctrine/orm to 3.6.2 for consistent dsn parsing
andrewmy Dec 20, 2025
ca61adf
Fix dbal compat
andrewmy Dec 20, 2025
e2847dd
Bump ratchet/pawl to ^0.4.3 for guzzle api consistency
andrewmy Dec 20, 2025
793fdb0
Bump ratchet/rfc6455 to ^0.4 for api consistency
andrewmy Dec 20, 2025
174c925
Fix a signature
andrewmy Dec 20, 2025
0e40e6e
Drop Symfony 6
andrewmy Dec 21, 2025
03fc6ff
Move to ramsey/composer-install@v3
andrewmy Dec 21, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix the method visibility check
  • Loading branch information
andrewmy committed Nov 29, 2025
commit 65c7385df0af0b004ee1c1b443c30d5d2334e8e1
6 changes: 5 additions & 1 deletion pkg/dbal/ManagerRegistryConnectionFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
use Doctrine\Persistence\ManagerRegistry;
use Interop\Queue\ConnectionFactory;
use Interop\Queue\Context;
use ReflectionMethod;

class ManagerRegistryConnectionFactory implements ConnectionFactory
{
Expand Down Expand Up @@ -61,7 +62,10 @@ private function establishConnection(): Connection
{
/** @var Connection $connection */
$connection = $this->registry->getConnection($this->config['connection_name']);
if (method_exists($connection, 'connect')) {
if (
method_exists($connection, 'connect')
&& (new ReflectionMethod($connection, 'connect'))->isPublic()
) {
// DBAL < 4
$connection->connect();
} else {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
use Doctrine\Persistence\ManagerRegistry;
use Enqueue\Consumption\Context\MessageReceived;
use Enqueue\Consumption\MessageReceivedExtensionInterface;
use ReflectionMethod;

class DoctrinePingConnectionExtension implements MessageReceivedExtensionInterface
{
Expand Down Expand Up @@ -36,7 +37,10 @@ public function onMessageReceived(MessageReceived $context): void
);

$connection->close();
if (method_exists($connection, 'connect')) {
if (
method_exists($connection, 'connect')
&& (new ReflectionMethod($connection, 'connect'))->isPublic()
) {
// DBAL < 4
$connection->connect();
} else {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
use Interop\Queue\Processor;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase;
use ReflectionMethod;

class DoctrinePingConnectionExtensionTest extends TestCase
{
Expand Down Expand Up @@ -41,7 +42,10 @@ public function testShouldNotReconnectIfConnectionIsOK()
->expects($this->never())
->method('close')
;
if (method_exists(Connection::class, 'connect')) {
if (
method_exists(Connection::class, 'connect')
&& (new ReflectionMethod(Connection::class, 'connect'))->isPublic()
) {
// DBAL < 4
$connection->expects($this->never())
->method('connect');
Expand Down Expand Up @@ -87,7 +91,10 @@ public function testShouldDoesReconnectIfConnectionFailed()
->expects($this->once())
->method('close')
;
if (method_exists(Connection::class, 'connect')) {
if (
method_exists(Connection::class, 'connect')
&& (new ReflectionMethod(Connection::class, 'connect'))->isPublic()
) {
// DBAL < 4
$connection->expects($this->once())
->method('connect');
Expand Down
Loading