Contract propagation for subclasses #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| throw new DomainException($errorMessage); | ||
| } | ||
| } | ||
| } |
| { | ||
| $this->value += $variable; | ||
| } | ||
| } |
|
Hello! Thank your for this PR, I'll review it when I will be free ) Great job! |
| throw new ContractViolation($invocation, $annotation->value, $e); | ||
| } | ||
| } | ||
| (new PreconditionContract($this->reader))->check($invocation); |
There was a problem hiding this comment.
I don't like, that we create new instances of PreconditionContract on every method call. This is very expensive. You should avoid unnecessary object initialization and method calls for better performance.
One more suggest: if you want to separate this logic into smaller classes, then it will be better to define 3 separate aspects.
There was a problem hiding this comment.
All right, we can move object initialization to ContractCheckerAspect::construct
|
Looks good! Thank you! 👍 However I will polish several things to keep core simple and fast. Don't you mind? |
Closed
|
@lisachenko No problem, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement releated to #9, with next pull request we can add support for interfaces.
Little reorganization of classes into smaller ones