Skip to content

[WIP] Spock to JUnit migration #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

[WIP] Spock to JUnit migration #1249

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ad1bbf9
refactor: rename tests on Groovy and add Legacy prefix to their names.
php-coder Jan 27, 2020
6632676
refactor: rename methods to avoid escaping of a single quote.
php-coder Jan 27, 2020
b2791d8
refactor: explicitly specify members type.
php-coder Jan 27, 2020
2cae593
refactor: split "where" block and its arguments
php-coder Jan 27, 2020
7408a66
style: add white spaces where needed and remove trailing tabs.
php-coder Jan 27, 2020
d93b668
[DO NOT MERGE] run only a single profile.
php-coder Jan 27, 2020
cab975b
refactor: propagate assertThat().isNotNull()
php-coder Jan 27, 2020
4079d28
refactor: use assertThat() for hours/minutes/seconds/milliseconds.
php-coder Jan 27, 2020
3b3bd49
refactor: use assertThat().isToday() and .isInSameDayAs() to simplify…
php-coder Jan 27, 2020
fad9082
refactor: use getters explicitly.
php-coder Jan 27, 2020
1b23a09
refactor: make a constant be accessible in other packages.
php-coder Jan 27, 2020
f9c4357
refactor(TestObjects.createUsersActivationFullDto): remove an interme…
php-coder Jan 27, 2020
65d62d8
refactor: add explicit import for Date class.
php-coder Jan 28, 2020
0b5a2f7
refactor: don't call init() method on the interface that doesn't have…
php-coder Jan 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: add explicit import for Date class. 
This change is needed in order to simplify automated porting of tests.

Part of 1246
  • Loading branch information
@php-coder
php-coder committed Jan 28, 2020
commit 65d62d85fc1957dc94b3497e42f5444a9614b9de
3 changes: 3 additions & 0 deletions src/test/groovy/ru/mystamps/web/feature/site/LegacyCronServiceImplTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ package ru.mystamps.web.feature.site

import static org.assertj.core.util.DateUtil.yesterday

@SuppressWarnings('UnnecessaryGroovyImport')
import java.util.Date

import org.assertj.core.api.WithAssertions
import org.slf4j.helpers.NOPLogger
import ru.mystamps.web.feature.account.UserService
Expand Down