feat: Support Casbin UpdatableAdapter interface #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@techoner plz review |
leeqvip
requested changes
Sep 23, 2021
src/Adapter.php
Outdated
| $removedRule = $removedRule->toArray(); | ||
| $removedRule = array_filter($removedRule, function ($value) { | ||
| return !is_null($value) && $value !== ''; | ||
| }); |
There was a problem hiding this comment.
@basakest For filtering rules, please refer to: https://github.com/php-casbin/dbal-adapter/blob/master/src/Adapter.php#L435
leeqvip
requested changes
Sep 25, 2021
| $this->addPolicies($sec, $ptype, $newRules); | ||
| $transaction->commit(); | ||
| } catch (\Exception $e) { | ||
| $transaction->rollBack(); |
There was a problem hiding this comment.
@basakest The exception should not be ignored here, same as updatePolicies().
feat: Support Casbin UpdatableAdapter interface feat: Support Casbin UpdatableAdapter interface
basakest
force-pushed
the
updatable-adapter
branch
from
09a274a to
163412f
Compare
leeqvip
approved these changes
Sep 26, 2021
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.