feat: add redis-caching #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alonexy Please fix test error |
added 2 commits
June 4, 2025 23:08
leeqvip
requested changes
Jun 5, 2025
leeqvip
requested changes
Jun 7, 2025
There was a problem hiding this comment.
@alonexy Don't change all the lines. I can't see which line was modified or added.
|
I'm wondering if this PR is really necessary, since CachedEnforcer already supports Redis caching. Would adding caching to the dbal-adapter be somewhat redundant in this case?🤔 |
leeqvip
approved these changes
Jun 15, 2025
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add Redis caching layer for policies
This commit introduces a Redis caching layer to the DBAL adapter to improve performance and reduce database load.
Features:
Policies loaded via loadPolicy and loadFilteredPolicy are now cached in Redis.
Configurable Redis connection parameters (host, port, password, database, TTL, prefix).
Automatic cache invalidation for the main policy cache (all_policies) when policies are modified.
A preheatCache() method to proactively load all policies into Redis.
The adapter remains fully functional if Redis is not configured.
Includes:
Updates to Adapter.php to integrate caching logic.
Addition of predis/predis as a dependency.
Unit tests for the caching functionality in AdapterWithRedisTest.php.
Documentation in README.md for the new feature.
Known limitations:
Cache invalidation for loadFilteredPolicy currently only clears the global all_policies key, not specific filtered policy keys, to avoid using KEYS in production with Predis.