Skip to content

Open pool for extension #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

babesflorin
Copy link

Question Answer
New feature? yes
License MIT

Description

I need to open the adapter for extension because I would like to override the methods that works with lists.
Real life scenario: I use Memcached as a cachePool and Redis as a tagStorePool. Right now when I append a key to a list it gets the list, appends the element to list and than saves the list. If I override appendListItem, removeListItem and use the native functionality of redis for working with lists it will be three times faster.

@codecov-io
Copy link

codecov-io commented Aug 23, 2018

Codecov Report

Merging #225 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #225   +/-   ##
=========================================
  Coverage     82.24%   82.24%           
  Complexity      615      615           
=========================================
  Files            33       33           
  Lines          1560     1560           
=========================================
  Hits           1283     1283           
  Misses          277      277
Impacted Files Coverage Δ Complexity Δ
src/Taggable/TaggablePSR6PoolAdapter.php 87.09% <100%> (ø) 36 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3bba52...c5ab3c9. Read the comment docs.

@rrelenschi
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants