fix appveyor due to changes in chocolatey php #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
photodude
commented
Feb 16, 2017
photodude
commented
- fix php install dir due to chocolatey versioned install directory changes for side by side installs
- fix version sorting to get current minor versions
- add correct caching of php and chocolatey
- fix php install dir due to chocolatey versioned install directory changes for side by side installs - fix version sorting to get current minor versions - add correct caching of php and chocolatey
|
@WyriHaximus ping for merge consideration |
|
@photodude yes sorry for the late reply, looks good although I still have my reservations about caching chocolatey but lets see how it works out. The sorting fix is really welcome 👍 . (I would like to add it to my post soon, unless you like to create a PR for that your self.) |
|
Thanks 👍 |
WyriHaximus
added a commit
to php-api-clients/middleware
that referenced
this pull request
Mar 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.