Skip to content

check for type #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Conversation

dvdknaap
Copy link
Contributor

Check for type to prevent never sending an ack message

@dvdknaap
Copy link
Contributor Author

@mihaileu could you merge this asap because more people will have this issue when they upgrade ?

Thanks

@mihaileu
Copy link
Collaborator

@Eloar could you take a peek ?

@Eloar
Copy link
Contributor

Eloar commented Nov 11, 2021

@mihaileu that is a fix for my oversight. I agree it should be merged asap.

@mihaileu mihaileu merged commit 9829eb0 into php-amqplib:master Nov 11, 2021
@dvdknaap dvdknaap deleted the fixNotSendingAckMessages branch November 11, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants