Consumer timeout wait #559
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the ability to set a timeout_wait flag for consumers. This ensures the consumer appropriately terminates when its connection is lost, rather than waiting for an idle timeout or a max execution timeout.
ramunasd
reviewed
Mar 24, 2021
| } else { | ||
| throw $e; | ||
| if ($this->gracefulMaxExecutionDateTime | ||
| && $this->gracefulMaxExecutionDateTime <= new \DateTime("@$now") |
Member
There was a problem hiding this comment.
Why not just use timestamps everywhere? I mean there is no point to use \DateTime here.
Author
There was a problem hiding this comment.
Yes, agreed that timestamps would be preferred. I introduced $lastActivityDateTime as \DateTime to match $gracefulMaxExecutionDateTime which was already in place.
Member
|
I see there is too much conflicts since last update. Please rebase and reopen as new PR. |
Author
|
This PR was opened about 3 years ago back when the repo was not being maintained, so it is perhaps just a little out of date 😄 However, it does appear that my changes were introduced by @constantable in 5542098. It looks like they are already in master, so there is no need for this PR or a new one. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to set a timeout_wait flag for consumers. This ensures the consumer appropriately terminates when its connection is lost, rather than waiting for an idle timeout or a max execution timeout.