added index capabilities

phonetworks · Jan 17, 2018 · 55a54c6 · 55a54c6
1 parent e5cb23f
commit 55a54c6
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 8 deletions.
diff --git a/src/Pho/Kernel/Foundation/Handlers/Set.php b/src/Pho/Kernel/Foundation/Handlers/Set.php
@@ -44,15 +44,12 @@ protected static function saveField(
         }
         elseif($helper->withIndex()) {
             // check if there is an index
+            // see: https://github.com/phonetworks/pho-microkernel/issues/12
+            if($kernel->live()) {
+                $kernel->index()->createIndex($particle->label(), $field_name);
+            }
         }
         parent::saveField($particle, $field_name, $field_value, $defer_persist, $helper);
-
-        /*if(!$defer_persist) {
-            $particle->attributes()->$field_name = $field_value;
-            return;
-        }
-        $particle->attributes()->quietSet($field_name, $field_value);
-        */
     }
 
 }
diff --git a/src/Pho/Kernel/Services/Index/IndexInterface.php b/src/Pho/Kernel/Services/Index/IndexInterface.php
@@ -104,4 +104,18 @@ public function checkNodeUniqueness(
         string $label = ""
     ): bool;
 
+
+    /**
+     * Creates an index
+     * 
+     * May be run over and over with no effect if it's duplicate
+     * Although not recommended.
+     *
+     * @param string $label Node label
+     * @param string $field_name Field name (not value!)
+     * 
+     * @return void
+     */
+    public function createIndex(string $label, string $field_name): void;
+
 }
diff --git a/tests/assets/compiled/UserWithUniqueFeatures.php b/tests/assets/compiled/UserWithUniqueFeatures.php
@@ -31,7 +31,7 @@ class UserWithUniqueFeatures extends User {
     const DEFAULT_MASK = 0xfffff;
 
     // added username with 3 chars min, 20 chars max, and must be unique!
-    const FIELDS = "{\"username\":{\"constraints\":{\"minLength\":3,\"maxLength\":20,\"uuid\":null,\"regex\":null,\"greaterThan\":null,\"lessThan\":null},\"directives\":{\"unique\":true, \"md5\":false,\"now\":false,\"default\":\"|_~_~NO!-!VALUE!-!SET~_~_|\"}},\"password\":{\"constraints\":{\"minLength\":null,\"maxLength\":null,\"uuid\":null,\"regex\":\"^[a-zA-Z0-9_]{4,12}$\",\"greaterThan\":null,\"lessThan\":null},\"directives\":{\"md5\":true,\"now\":false,\"default\":\"|_~_~NO!-!VALUE!-!SET~_~_|\"}},\"join_time\":{\"constraints\":{\"minLength\":null,\"maxLength\":null,\"uuid\":null,\"regex\":null,\"greaterThan\":null,\"lessThan\":null},\"directives\":{\"md5\":false,\"now\":true,\"default\":\"|_~_~NO!-!VALUE!-!SET~_~_|\"}},\"birthday\":{\"constraints\":{\"minLength\":null,\"maxLength\":null,\"uuid\":null,\"regex\":null,\"greaterThan\":null,\"lessThan\":null},\"directives\":{\"md5\":false,\"now\":false,\"default\":411436800}},\"about\":{\"constraints\":{\"minLength\":null,\"maxLength\":\"255\",\"uuid\":null,\"regex\":null,\"greaterThan\":null,\"lessThan\":null},\"directives\":{ \"md5\":false,\"now\":false,\"default\":\"\"}}}";
+    const FIELDS = "{\"username\":{\"constraints\":{\"minLength\":3,\"maxLength\":20,\"uuid\":null,\"regex\":null,\"greaterThan\":null,\"lessThan\":null},\"directives\":{\"unique\":true, \"md5\":false,\"now\":false,\"default\":\"|_~_~NO!-!VALUE!-!SET~_~_|\"}},\"password\":{\"constraints\":{\"minLength\":null,\"maxLength\":null,\"uuid\":null,\"regex\":\"^[a-zA-Z0-9_]{4,12}$\",\"greaterThan\":null,\"lessThan\":null},\"directives\":{\"md5\":true,\"now\":false,\"default\":\"|_~_~NO!-!VALUE!-!SET~_~_|\"}},\"join_time\":{\"constraints\":{\"minLength\":null,\"maxLength\":null,\"uuid\":null,\"regex\":null,\"greaterThan\":null,\"lessThan\":null},\"directives\":{\"md5\":false,\"now\":true,\"default\":\"|_~_~NO!-!VALUE!-!SET~_~_|\"}},\"birthday\":{\"constraints\":{\"minLength\":null,\"maxLength\":null,\"uuid\":null,\"regex\":null,\"greaterThan\":null,\"lessThan\":null},\"directives\":{\"md5\":false,\"now\":false,\"default\":411436800}},\"about\":{\"constraints\":{\"minLength\":null,\"maxLength\":\"255\",\"uuid\":null,\"regex\":null,\"greaterThan\":null,\"lessThan\":null},\"directives\":{\"index\": true, \"md5\":false,\"now\":false,\"default\":\"\"}}}";
 
     public function __construct(\Pho\Kernel\Kernel $kernel, \Pho\Lib\Graph\GraphInterface $graph , string $username, string $password, ?int $birthday = 411436800, ?string $about = "")
     {