Improving the comments for the app icon setting. #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a lot of confusion over what is the right way to set app icons. I myself struggled with this setting because the default icons generated by phonegap are also named "icon.png". When I placed an `icon.png` inside `img` folder, it didn't work. It's important to make it explicit in the documentation that the setting is taken relative the `config.xml` location.
mwbrooks
added a commit
that referenced
this pull request
May 12, 2014
[#149] Improving the comments for the app icon setting.
|
Thanks @manuganji, it's these kind of contributions that help make the entire development process a little more clear for everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a lot of confusion over what is the right way to set app icons. I myself struggled with this setting because the default icons generated by phonegap are also named "icon.png". When I placed an
icon.pnginsideimgfolder, it didn't work. It's important to make it explicit in the documentation that the setting is taken relative theconfig.xmllocation.