Replace requireCordovaModule with require for Cordova 9#554
Merged
purplecabbage merged 1 commit intophonegap:masterfrom Sep 17, 2019
erisu:cordova9-require-fix
Merged
Replace requireCordovaModule with require for Cordova 9#554purplecabbage merged 1 commit intophonegap:masterfrom erisu:cordova9-require-fix
purplecabbage merged 1 commit intophonegap:masterfrom
erisu:cordova9-require-fix
Conversation
chriswaustin
added a commit
to chriswaustin/phonegap-app-developer
that referenced
this pull request
Oct 1, 2019
fix: replace requireCordovaModule with require for Cordova 9 (phonegap#554)
astropoint
added a commit
to astropoint/phonegap-app-developer
that referenced
this pull request
Nov 5, 2019
fix: replace requireCordovaModule with require for Cordova 9 (phonegap#554)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Cordova-Lib 9.x used in Cordova 9 has deprecated using
requireCordovaModuleto require for non-Cordova modules.apache/cordova-lib#707
Changes
q@^1.5.1as a dependency.requireCordovaModuleusage withrequire.Test steps
npm tnpm run lintnpm run phonegapMore testing may be required.
Other found issues outside of the changes scope
adhoc-androidandadhoc-iosfails but not related to this change.