Skip to content

Replace requireCordovaModule with require for Cordova 9#554

Merged
purplecabbage merged 1 commit intophonegap:masterfrom
erisu:cordova9-require-fix
Sep 17, 2019
Merged

Replace requireCordovaModule with require for Cordova 9#554
purplecabbage merged 1 commit intophonegap:masterfrom
erisu:cordova9-require-fix

Conversation

@erisu
Copy link
Contributor

@erisu erisu commented Apr 16, 2019

Background

Cordova-Lib 9.x used in Cordova 9 has deprecated using requireCordovaModule to require for non-Cordova modules.

apache/cordova-lib#707

Changes

  • Added q@^1.5.1 as a dependency.
  • Replaced requireCordovaModule usage with require.

Test steps

  • npm t
  • npm run lint
  • npm run phonegap

More testing may be required.

Other found issues outside of the changes scope

adhoc-android and adhoc-ios fails but not related to this change.

Error: Failed to fetch plugin cordova-plugin-hockeyapp@5.1.2 via registry.
Probably this is either a connection problem, or plugin spec is incorrect.
...
npm ERR! peerinvalid The package eslint-config-standard@12.0.0 does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer eslint-config-semistandard@12.0.1 wants eslint-config-standard@^11.0.0

@purplecabbage purplecabbage merged commit 3b72a42 into phonegap:master Sep 17, 2019
@erisu erisu deleted the cordova9-require-fix branch September 17, 2019 07:47
chriswaustin added a commit to chriswaustin/phonegap-app-developer that referenced this pull request Oct 1, 2019
fix: replace requireCordovaModule with require for Cordova 9 (phonegap#554)
astropoint added a commit to astropoint/phonegap-app-developer that referenced this pull request Nov 5, 2019
fix: replace requireCordovaModule with require for Cordova 9 (phonegap#554)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants