fix for #9

Author: goya

lib/commands/ls.js

@@ -1,6 +1,6 @@
 {
   "name": "pgb-cli",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "description": "nodeJS CLI to PhoneGap Build",
   "keywords": [
     "PhoneGap",

package.json

@@ -5,8 +5,7 @@ const has = require('./helpers/validators')
 const toTitleCase = (str) => str.replace(/\w\S*/g, (txt) => txt.charAt(0).toUpperCase() + txt.substr(1).toLowerCase())
 
 const print = (data) => {
-  let diff = Math.max(process.stdout.columns - 80, 0)
-  let title_length = 15 + diff
+  let title_length = (15 + Math.max(process.stdout.columns - 80, 0)) || 80
   let str = ''
   let bare = []
 

src/commands/ls.js

@@ -1,20 +1,22 @@
 const command = require('../../src/commands/ls')
 const validators = require('../../src/commands/helpers/validators')
 
-describe('qyarn jest', () => {
+describe('ls', () => {
   let apps
 
   beforeEach(() => {
     require('../_helpers/pgb')({ commands: [ 'ls' ] })
     apps = { apps: [
-      { id: 1, status: { ios: 'error', android: 'skip', winphone: 'pending' }, last_build: '4 march 1994', foo: 'bar', zig: null },
+      { id: 1, title: '123456789012345678901234567890', status: { ios: 'error', android: 'skip', winphone: 'pending' }, last_build: '4 march 1994', foo: 'bar', zig: null },
       { id: 12, status: { ios: 'error', android: 'unknown', winphone: 'complete' }, foo: {a: 12} }
     ] }
     pgb.api.getApps = jest.fn(() => Promise.resolve(apps))
+    process.stdout.columns = 10
   })
 
   afterAll(() => {
     delete global.pgb
+    process.stdout.columns = 10
   })
 
   test('should validate', () => {
@@ -26,6 +28,31 @@ describe('qyarn jest', () => {
   })
 
   test('should print apps details', () => {
+    return Promise.resolve()
+      .then(command)
+      .then(() => {
+        let call = pgb.print.mock.calls[0]
+        expect(call[0].pretty).toMatch(/App Id[^]*1[^]*123456789012\.\.\.[^]*FAILED[^]*SKIPPED[^]*BUILDING[^]*1994-03-04[^]*12[^]*FAILED[^]*BUILDING[^]*SUCCESS/)
+        expect(call[0].json).toEqual(apps)
+        expect(call[0].bare).toEqual('1\n12')
+        expect(pgb.api.getApps).toHaveBeenCalled()
+      })
+  })
+
+  test('should print apps details even when not stdout.tty', () => {
+    process.stdout.columns = undefined
+    return Promise.resolve()
+      .then(command)
+      .then(() => {
+        let call = pgb.print.mock.calls[0]
+        expect(call[0].pretty).toMatch(/App Id[^]*1[^]*123456789012345678901234567890[^]*FAILED[^]*SKIPPED[^]*BUILDING[^]*1994-03-04[^]*12[^]*FAILED[^]*BUILDING[^]*SUCCESS/)
+        expect(call[0].json).toEqual(apps)
+        expect(call[0].bare).toEqual('1\n12')
+        expect(pgb.api.getApps).toHaveBeenCalled()
+      })
+  })
+
+  test('should truncate properly if no tty', () => {
     return Promise.resolve()
       .then(command)
       .then(() => {