Just use euo pipefail instead of l

phofl · Aug 16, 2023 · 3552e77 · 3552e77
1 parent 7b168da
commit 3552e77
Show file tree

Hide file tree

Showing 8 changed files with 20 additions and 24 deletions.
diff --git a/.github/actions/build_pandas/action.yml b/.github/actions/build_pandas/action.yml
@@ -13,14 +13,14 @@ runs:
         micromamba info
         micromamba list
         pip list --pre
-      shell: bash -el {0}
+      shell: bash -euo pipefail {0}
 
     - name: Uninstall existing Pandas installation
       run: |
         if pip show pandas 1>/dev/null; then
           pip uninstall -y pandas
         fi
-      shell: bash -el {0}
+      shell: bash -euo pipefail {0}
 
     - name: Build Pandas
       run: |
@@ -29,4 +29,4 @@ runs:
         else
           pip install . --no-build-isolation -v
         fi
-      shell: bash -el {0}
+      shell: bash -euo pipefail {0}
diff --git a/.github/actions/run-tests/action.yml b/.github/actions/run-tests/action.yml
@@ -4,7 +4,7 @@ runs:
   steps:
     - name: Test
       run: ci/run_tests.sh
-      shell: bash -el {0}
+      shell: bash -euo pipefail {0}
 
     - name: Publish test results
       uses: actions/upload-artifact@v3
@@ -15,7 +15,7 @@ runs:
 
     - name: Report Coverage
       run: coverage report -m
-      shell: bash -el {0}
+      shell: bash -euo pipefail {0}
       if: failure()
 
     - name: Upload coverage to Codecov

diff --git a/.github/workflows/code-checks.yml b/.github/workflows/code-checks.yml
@@ -24,7 +24,7 @@ jobs:
     runs-on: ubuntu-22.04
     defaults:
       run:
-        shell: bash -el {0}
+        shell: bash -euo pipefail {0}
 
     concurrency:
       # https://github.community/t/concurrecy-not-work-for-push/183068/7
@@ -100,7 +100,7 @@ jobs:
     runs-on: ubuntu-22.04
     defaults:
       run:
-        shell: bash -el {0}
+        shell: bash -euo pipefail {0}
 
     concurrency:
       # https://github.community/t/concurrecy-not-work-for-push/183068/7
@@ -131,7 +131,7 @@ jobs:
     runs-on: ubuntu-22.04
     defaults:
       run:
-        shell: bash -el {0}
+        shell: bash -euo pipefail {0}
 
     concurrency:
       # https://github.community/t/concurrecy-not-work-for-push/183068/7

diff --git a/.github/workflows/comment-commands.yml b/.github/workflows/comment-commands.yml
@@ -36,7 +36,7 @@ jobs:
     if: github.event.issue.pull_request && startsWith(github.event.comment.body, '@github-actions benchmark')
     defaults:
       run:
-        shell: bash -el {0}
+        shell: bash -euo pipefail {0}
     env:
       ENV_FILE: environment.yml
       COMMENT: ${{github.event.comment.body}}

diff --git a/.github/workflows/docbuild-and-upload.yml b/.github/workflows/docbuild-and-upload.yml
@@ -32,7 +32,7 @@ jobs:
 
     defaults:
       run:
-        shell: bash -el {0}
+        shell: bash -euo pipefail {0}
 
     steps:
     - name: Checkout

diff --git a/.github/workflows/package-checks.yml b/.github/workflows/package-checks.yml
@@ -16,7 +16,7 @@ permissions:
 
 defaults:
   run:
-    shell: bash -el {0}
+    shell: bash -euo pipefail {0}
 
 jobs:
   pip:
@@ -47,7 +47,7 @@ jobs:
       - name: Pip install with extra
         run: |
           python -m pip install .[${{ matrix.extra }}] -v
-        shell: bash -el {0}
+        shell: bash -euo pipefail {0}
   conda_forge_recipe:
     if: ${{ github.event.label.name == 'Build' || contains(github.event.pull_request.labels.*.name, 'Build') || github.event_name == 'push'}}
     runs-on: ubuntu-22.04

diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml
@@ -18,7 +18,7 @@ permissions:
 
 defaults:
   run:
-    shell: bash -el {0}
+    shell: bash -euo pipefail {0}
 
 jobs:
   ubuntu:
@@ -337,10 +337,8 @@ jobs:
         with:
           python-version: '3.12-dev'
 
-      - name: Build Environment
+      - name: Install Environment
         run: |
-          ${{ steps.pydev.outputs.python-path }} -m venv ~/virtualenvs/pandas-dev
-          . ~/virtualenvs/pandas-dev/bin/activate
           python --version
           python -m pip install --upgrade pip setuptools wheel meson[ninja]==1.0.1 meson-python==0.13.1
           python -m pip install --pre --extra-index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple numpy
@@ -350,6 +348,4 @@ jobs:
           python -m pip list
 
       - name: Run Tests
-        run: |
-          . ~/virtualenvs/pandas-dev/bin/activate
-          ci/run_tests.sh
+        uses: ./.github/actions/run-tests
diff --git a/.github/workflows/wheels.yml b/.github/workflows/wheels.yml
@@ -73,7 +73,7 @@ jobs:
 
       - name: Output sdist name
         id: save-path
-        shell: bash -el {0}
+        shell: bash -euo pipefail {0}
         run: echo "sdist_name=$(ls ./dist)" >> "$GITHUB_OUTPUT"
 
   build_wheels:
@@ -123,7 +123,7 @@ jobs:
 
       - name: Output sdist name (macOS)
         id: save-path
-        shell: bash -el {0}
+        shell: bash -euo pipefail {0}
         run: echo "sdist_name=$(ls ./dist)" >> "$GITHUB_ENV"
 
       # Python version used to build sdist doesn't matter
@@ -135,7 +135,7 @@ jobs:
 
       - name: Output sdist name (macOS)
         id: save-path2
-        shell: bash -el {0}
+        shell: bash -euo pipefail {0}
         run: echo "sdist_name=$(cd ./dist && ls -d */)" >> "$GITHUB_ENV"
 
       - name: Build wheels
@@ -158,7 +158,7 @@ jobs:
           cache-environment: true
 
       - name: Validate wheel RECORD
-        shell: bash -el {0}
+        shell: bash -euo pipefail {0}
         run: for whl in $(ls wheelhouse); do wheel unpack wheelhouse/$whl -d /tmp; done
 
       # Testing on windowsservercore instead of GHA runner to fail on missing DLLs
@@ -181,7 +181,7 @@ jobs:
 
       - name: Upload wheels & sdist
         if: ${{ success() && (env.IS_SCHEDULE_DISPATCH == 'true' || env.IS_PUSH == 'true') }}
-        shell: bash -el {0}
+        shell: bash -euo pipefail {0}
         env:
           PANDAS_STAGING_UPLOAD_TOKEN: ${{ secrets.PANDAS_STAGING_UPLOAD_TOKEN }}
           PANDAS_NIGHTLY_UPLOAD_TOKEN: ${{ secrets.PANDAS_NIGHTLY_UPLOAD_TOKEN }}