check children for PHX-SKIP as well #4097
Closed
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I think the nested morphdom call should properly handle children marked as skip, so this shouldn’t be necessary. But I can take a look myself some time soon! |
Collaborator
|
Please try #4106 if you can! |
Author
Thank you very much <3 works like a charm |
Collaborator
|
Thank you for reporting back! A new release should be out later this week :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a short test this fixes #4095
But I suspect the root cause lies somewhere else. Just want to document my findings and will update the PR as I will dig deeper.
EDIT: this only works for the first level of children and not deeply nested nodes