Refactor error handling. #3470
Merged
Refactor error handling. #3470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For plug_status errors during connected mount, we now sign an instruction within an cookie to instruct the dead render to trigger the plug error pipeline. In dev, this will show the plug debugger with stacktrace. In prod, this will show the 400..50 error pages. For child LV's, we now attempt to remount a failed child up to a configurable maximum, then failsafe keep the child in a dead state. Co-authored-by: Steffen Deusch <steffen@deusch.me>
SteffenDE
reviewed
Oct 15, 2024
| exception: exception_mod, | ||
| stack: stack | ||
| }) | ||
|
|
||
| GenServer.reply(from, {:error, %{reason: "reload", status: status, token: token}}) | ||
| {:stop, :shutdown, :no_state} | ||
| else | ||
| IO.inspect({view, connect_params}) |
There was a problem hiding this comment.
Looks like you forgot that one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For plug_status errors during connected mount, we now sign an instruction within an cookie to instruct the dead render to trigger the plug error pipeline.
In dev, this will show the plug debugger with stacktrace. In prod, this will show the 400..500 error pages.
For child LV's, we now attempt to remount a failed child up to a configurable maximum, then failsafe keep the child in a dead state.
Borrows from #3280
Closes #3280
Closes #3257