-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"phx-disable-with" disables button completely #2993
Labels
Comments
PJUllrich
changed the title
"phx-disable-with" disabled button completely
"phx-disable-with" disables button completely
Jan 9, 2024
This only happens when the server sends no diff. I will take a look. Thanks! |
Thank you @chrismccord May I ask when you plan on releasing the new version with the bugfix on Hex? |
SteffenDE
added a commit
to SteffenDE/phoenix_live_view
that referenced
this issue
Jan 14, 2024
SteffenDE
added a commit
to SteffenDE/phoenix_live_view
that referenced
this issue
Jan 15, 2024
references phoenixframework#3009 references phoenixframework#2993 references phoenixframework#1759
SteffenDE
added a commit
to SteffenDE/phoenix_live_view
that referenced
this issue
Jan 15, 2024
references phoenixframework#3009 references phoenixframework#2993 references phoenixframework#1759
SteffenDE
added a commit
to SteffenDE/phoenix_live_view
that referenced
this issue
Jan 15, 2024
references phoenixframework#3009 references phoenixframework#2993 references phoenixframework#1759
chrismccord
added a commit
that referenced
this issue
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment
1.15.7
1.17.10
0.20.1
macOS Sonoma
Arc (Chrome)
Yes
Actual behavior
When I set the
phx-disable-with
flag on a button and click the button, the button doesn't re-enable after the server sent the response.Usually, the button would be disabled right after I clicked it and while the server processes the event, but then re-enable after the server responds to the event and the browser received the response. However, if I set the
phx-disable-with
parameter, the button stays disabled and I need to reload the page to fix it.Here's a demo. The
HTML Button
has nophx-disable-with
set and works as expected. The other two buttons havephx-disable-with
and stay disabled. I also tested whether this is a LiveView vs LiveComponent or "HTML Button" vs CoreComponent button issue, but this doesn't seem to make a difference.I created an example repo that replicates this issue here: https://github.com/PJUllrich/button
Expected behavior
The button should re-enable after the server sent a response.
The text was updated successfully, but these errors were encountered: