[RTLD] Dynamic linker #214

badochov · 2024-01-30T15:25:05Z

Description

Motivation and Context

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

Already covered by automatic testing.
New test added: (add PR link here).
Tested by hand on: (list targets here).

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing linter checks and tests passed.
My changes generate no new compilation warnings for any of the targets.

Special treatment

This PR needs additional PRs to work (list the PRs, preferably in merge-order).
I will merge this PR by myself when appropriate.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

clang-format-pr

github-actions · 2024-01-30T15:25:28Z

ld.elf_so/arch/aarch64/Makefile.inc

@@ -0,0 +1,12 @@
+# $NetBSD: Makefile.inc,v 1.3 2021/12/04 08:53:34 skrll Exp $


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

# $NetBSD: Makefile.inc,v 1.3 2021/12/04 08:53:34 skrll Exp $

#$NetBSD : Makefile.inc, v 1.3 2021 / 12 / 04 08 : 53 : 34 skrll Exp $

github-actions · 2024-01-30T15:25:28Z

ld.elf_so/arch/aarch64/Makefile.inc

@@ -0,0 +1,12 @@
+# $NetBSD: Makefile.inc,v 1.3 2021/12/04 08:53:34 skrll Exp $
+
+SRCS+=		rtld_start.S mdreloc.c


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

SRCS+= rtld_start.S mdreloc.c

SRCS += rtld_start.S mdreloc.c

github-actions · 2024-01-30T15:25:29Z

ld.elf_so/arch/aarch64/Makefile.inc

+# XXX Should not be in CPPFLAGS!
+CPPFLAGS+=	-fpic


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

# XXX Should not be in CPPFLAGS!

CPPFLAGS+= -fpic

#XXX Should not be in CPPFLAGS !

CPPFLAGS += -fpic

github-actions · 2024-01-30T15:25:29Z

ld.elf_so/arch/aarch64/Makefile.inc

+CPPFLAGS+=	-DELFSIZE=64
+CPPFLAGS+=	-DELF_NOTE_MARCH_DESC=\"${LDELFSO_MACHINE_ARCH}\"
+CPPFLAGS+=	-DRTLD_ARCH_CALL_IFUNC


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

CPPFLAGS+= -DELFSIZE=64

CPPFLAGS+= -DELF_NOTE_MARCH_DESC=\"${LDELFSO_MACHINE_ARCH}\"

CPPFLAGS+= -DRTLD_ARCH_CALL_IFUNC

CPPFLAGS += -DELFSIZE = 64 CPPFLAGS += -DELF_NOTE_MARCH_DESC =\"${LDELFSO_MACHINE_ARCH}\"

CPPFLAGS += -DRTLD_ARCH_CALL_IFUNC

github-actions · 2024-01-30T15:25:29Z

ld.elf_so/arch/aarch64/Makefile.inc

+CPPFLAGS+=	-DELF_NOTE_MARCH_DESC=\"${LDELFSO_MACHINE_ARCH}\"
+CPPFLAGS+=	-DRTLD_ARCH_CALL_IFUNC
+
+LDFLAGS+=	-Wl,-e,_rtld_start


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

LDFLAGS+= -Wl,-e,_rtld_start

LDFLAGS += -Wl,

-e, _rtld_start

github-actions · 2024-01-30T15:25:31Z

ld.elf_so/arch/aarch64/mdreloc.c

+			new_value = _rtld_resolve_ifunc(defobj, def);
+		} else {
+			new_value = (Elf_Addr)(defobj->relocbase +
+			     def->st_value);
+		}
+		rdbg(("bind now/fixup in %s --> old=%p new=%p",
+		    defobj->strtab + def->st_name, (void *)*where,
+		    (void *)new_value));
+		if (*where != new_value)
+			*where = new_value;
+		if (tp)
+			*tp = new_value;
+		break;
+	case R_TYPE(TLSDESC):
+		_rtld_tlsdesc_fill(obj, rela, where, SYMLOOK_IN_PLT);
+		break;


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

new_value = _rtld_resolve_ifunc(defobj, def);

} else {

new_value = (Elf_Addr)(defobj->relocbase +

def->st_value);

}

rdbg(("bind now/fixup in %s --> old=%p new=%p",

defobj->strtab + def->st_name, (void *)*where,

(void *)new_value));

if (*where != new_value)

*where = new_value;

if (tp)

*tp = new_value;

break;

case R_TYPE(TLSDESC):

_rtld_tlsdesc_fill(obj, rela, where, SYMLOOK_IN_PLT);

break;

if (ELF_ST_TYPE(def->st_info) == STT_GNU_IFUNC) {

if (tp == NULL)

return 0;

new_value = _rtld_resolve_ifunc(defobj, def);

}

else {

new_value = (Elf_Addr)(defobj->relocbase +

def->st_value);

}

rdbg(("bind now/fixup in %s --> old=%p new=%p",

defobj->strtab + def->st_name, (void *)*where,

(void *)new_value));

if (*where != new_value)

*where = new_value;

if (tp)

*tp = new_value;

break;

case R_TYPE(TLSDESC):

_rtld_tlsdesc_fill(obj, rela, where, SYMLOOK_IN_PLT);

break;

github-actions · 2024-01-30T15:25:31Z

ld.elf_so/arch/aarch64/mdreloc.c

+int
+_rtld_relocate_plt_objects(const Obj_Entry *obj)


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

int

_rtld_relocate_plt_objects(const Obj_Entry *obj)

int _rtld_relocate_plt_objects(const Obj_Entry *obj)

github-actions · 2024-01-30T15:25:31Z

ld.elf_so/arch/alpha/Makefile.inc

@@ -0,0 +1,11 @@
+#	$NetBSD: Makefile.inc,v 1.12 2005/06/04 16:17:17 lukem Exp $


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

# $NetBSD: Makefile.inc,v 1.12 2005/06/04 16:17:17 lukem Exp $

#$NetBSD : Makefile.inc, v 1.12 2005 / 06 / 04 16 : 17 : 17 lukem Exp $

github-actions · 2024-01-30T15:25:31Z

ld.elf_so/arch/alpha/Makefile.inc

@@ -0,0 +1,11 @@
+#	$NetBSD: Makefile.inc,v 1.12 2005/06/04 16:17:17 lukem Exp $
+
+SRCS+=		rtld_start.S alpha_reloc.c


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

SRCS+= rtld_start.S alpha_reloc.c

SRCS += rtld_start.S alpha_reloc.c

github-actions · 2024-01-30T15:25:31Z

ld.elf_so/arch/alpha/Makefile.inc

+# XXX Should not be in CPPFLAGS!
+CPPFLAGS+=	-fpic -mno-fp-regs


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

# XXX Should not be in CPPFLAGS!

CPPFLAGS+= -fpic -mno-fp-regs

#XXX Should not be in CPPFLAGS !

CPPFLAGS += -fpic - mno - fp - regs

github-actions · 2024-01-30T15:25:38Z

ld.elf_so/rtld.c

+	/*
+         * On entry, the dynamic linker itself has not been relocated yet.
+         * Be very careful not to reference any global data until after
+         * _rtld_init has returned.  It is OK to reference file-scope statics


[codespell] _{reported by reviewdog 🐶}
statics ==> statistics

github-actions · 2024-01-30T15:25:39Z

ld.elf_so/rtld.c

+	_rtld_pagesz = (int)pAUX_pagesz->a_v;
+	_rtld_init((caddr_t)pAUX_base->a_v, (caddr_t)relocbase, execname);
+
+	/* Init staticly linked libc. */


[codespell] _{reported by reviewdog 🐶}
staticly ==> statically

github-actions · 2024-01-30T15:25:39Z

ld.elf_so/ld.elf_so.1

+.Os
+.Sh NAME
+.Nm ld.elf_so
+.Nd run-time link-editor (linker)


[codespell] _{reported by reviewdog 🐶}
Nd ==> And, 2nd

github-actions · 2024-01-30T15:25:39Z

ld.elf_so/exec_elf.h

+#define EM_CLOUDSHIELD	192	/* CloudShield architecture family */
+#define EM_COREA_1ST	193	/* KIPO-KAIST Core-A 1st generation processor family */
+#define EM_COREA_2ND	194	/* KIPO-KAIST Core-A 2nd generation processor family */
+#define EM_ARC_COMPACT2	195	/* Synopsys ARCompact V2 */


[codespell] _{reported by reviewdog 🐶}
Synopsys ==> Synopsis

github-actions · 2024-01-30T15:25:39Z

ld.elf_so/exec_elf.h

+#define SHF_MASKOS	     0x0ff00000 /* Operating system specific values */
+#define SHF_MASKPROC	     0xf0000000 /* Processor-specific values */
+#define SHF_ORDERED	     0x40000000 /* Ordering requirement (Solaris) */
+#define SHF_EXCLUDE	     0x80000000 /* Excluded unless unles ref/alloc


[codespell] _{reported by reviewdog 🐶}
unles ==> unless

github-actions · 2024-01-30T15:25:39Z

ld.elf_so/arch/vax/rtld_start.S

+20:
+	/*
+	 * Since the calling standard says only r6-r11 should be saved,
+	 * that simplies things for us.  That means we can use r0-r5 as


[codespell] _{reported by reviewdog 🐶}
simplies ==> implies, simplifies

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

clang-format-pr

github-actions · 2024-01-30T16:04:46Z

ld.elf_so/arch/alpha/Makefile.inc

+CPPFLAGS+=	-DELFSIZE=64
+#CPPFLAGS+=	-DRTLD_DEBUG_ALPHA


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

CPPFLAGS+= -DELFSIZE=64

#CPPFLAGS+= -DRTLD_DEBUG_ALPHA

CPPFLAGS += -DELFSIZE = 64

#CPPFLAGS += -DRTLD_DEBUG_ALPHA

github-actions · 2024-01-30T16:04:46Z

ld.elf_so/arch/alpha/Makefile.inc

+CPPFLAGS+=	-DELFSIZE=64
+#CPPFLAGS+=	-DRTLD_DEBUG_ALPHA
+
+LDFLAGS+=	-Wl,-e,_rtld_start


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

LDFLAGS+= -Wl,-e,_rtld_start

LDFLAGS += -Wl,

-e, _rtld_start

github-actions · 2024-01-30T16:04:46Z

ld.elf_so/arch/alpha/alpha_reloc.c

+ */
+
+/*
+ * Copyright 1996, 1997, 1998, 1999 John D. Polstra.   


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

* Copyright 1996, 1997, 1998, 1999 John D. Polstra.

* Copyright 1996, 1997, 1998, 1999 John D. Polstra.

github-actions · 2024-01-30T16:04:46Z

ld.elf_so/arch/alpha/alpha_reloc.c

+/*
+ * Copyright 1996, 1997, 1998, 1999 John D. Polstra.   
+ * All rights reserved.
+ *           


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

*

*

github-actions · 2024-01-30T16:04:47Z

ld.elf_so/arch/alpha/alpha_reloc.c

+ *           
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met: 


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

* are met:

* are met:

github-actions · 2024-01-30T16:04:48Z

ld.elf_so/arch/alpha/alpha_reloc.c

+		if (tp == NULL)
+			return 0;
+		new_value = _rtld_resolve_ifunc(defobj, def);
+	} else {


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

} else {

}

else {

github-actions · 2024-01-30T16:04:48Z

ld.elf_so/arch/alpha/alpha_reloc.c

+		new_value = (Elf_Addr)(defobj->relocbase + def->st_value);
+	}
+	rdbg(("bind now/fixup in %s --> old=%p new=%p",
+	    defobj->strtab + def->st_name, (void *)*where, (void *)new_value));


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

defobj->strtab + def->st_name, (void *)*where, (void *)new_value));

defobj->strtab + def->st_name, (void *)*where, (void *)new_value));

github-actions · 2024-01-30T16:04:48Z

ld.elf_so/arch/alpha/alpha_reloc.c

+		 * so this test will fail as it would for the new PLT
+		 * entry format.
+		 */
+		if (obj->pltgot[2] == (Elf_Addr) &_rtld_bind_start_old) {


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

if (obj->pltgot[2] == (Elf_Addr) &_rtld_bind_start_old) {

if (obj->pltgot[2] == (Elf_Addr)&_rtld_bind_start_old) {

github-actions · 2024-01-30T16:04:49Z

ld.elf_so/arch/alpha/alpha_reloc.c

+		    (void *)stubaddr, (long)where - (long)stubaddr,
+		    (long)delta));


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

(void *)stubaddr, (long)where - (long)stubaddr,

(long)delta));

(void *)stubaddr, (long)where - (long)stubaddr,

(long)delta));

github-actions · 2024-01-30T16:04:49Z

ld.elf_so/arch/alpha/alpha_reloc.c

+			 * bits.
+			 */
+			insn[insncnt++] = 0x08 << 26 | 27 << 21 | 27 << 16 |
+			    (delta & 0xffff);


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

(delta & 0xffff);

(delta & 0xffff);

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

clang-format-pr

github-actions · 2024-01-30T16:07:12Z

ld.elf_so/arch/alpha/alpha_reloc.c

+				 * high 16 bits.
+				 */
+				insn[insncnt++] = 0x09 << 26 | 27 << 21 |
+				    27 << 16 | ((delta >> 16) & 0xffff);


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

27 << 16 | ((delta >> 16) & 0xffff);

27 << 16 | ((delta >> 16) & 0xffff);

github-actions · 2024-01-30T16:07:12Z

ld.elf_so/arch/alpha/alpha_reloc.c

+				insn[insncnt++] = 0x09 << 26 | 27 << 21 |
+				    27 << 16 | ((delta >> 16) & 0xffff);
+				rdbg(("  LDAH $27,%d($27)",
+				    (int16_t)(delta >> 16)));


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

(int16_t)(delta >> 16)));

(int16_t)(delta >> 16)));

github-actions · 2024-01-30T16:07:12Z

ld.elf_so/arch/alpha/alpha_reloc.c

+				rdbg(("  LDAH $27,%d($27)",
+				    (int16_t)(delta >> 16)));
+			}
+		} else {


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

} else {

}

else {

github-actions · 2024-01-30T16:07:13Z

ld.elf_so/arch/alpha/alpha_reloc.c

+				 * high 16 bits.
+				 */
+				insn[insncnt++] = 0x09 << 26 | 27 << 21 |
+				    27 << 16 | ((dhigh >> 16) & 0xffff);


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

27 << 16 | ((dhigh >> 16) & 0xffff);

27 << 16 | ((dhigh >> 16) & 0xffff);

github-actions · 2024-01-30T16:07:13Z

ld.elf_so/arch/alpha/alpha_reloc.c

+				insn[insncnt++] = 0x09 << 26 | 27 << 21 |
+				    27 << 16 | ((dhigh >> 16) & 0xffff);
+				rdbg(("  LDAH $27,%d($27)",
+				    (int16_t)(dhigh >> 16)));


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

(int16_t)(dhigh >> 16)));

(int16_t)(dhigh >> 16)));

github-actions · 2024-01-30T16:07:15Z

ld.elf_so/arch/arm/mdreloc.c

+		case DT_REL:
+			rel = (const Elf_Rel *)(relocbase + dynp->d_un.d_ptr);
+			break;
+		case DT_RELSZ:
+			relsz = dynp->d_un.d_val;
+			break;


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

case DT_REL:

rel = (const Elf_Rel *)(relocbase + dynp->d_un.d_ptr);

break;

case DT_RELSZ:

relsz = dynp->d_un.d_val;

break;

case DT_REL:

rel = (const Elf_Rel *)(relocbase + dynp->d_un.d_ptr);

break;

case DT_RELSZ:

relsz = dynp->d_un.d_val;

break;

github-actions · 2024-01-30T16:07:15Z

ld.elf_so/arch/arm/mdreloc.c

+ * It is possible for the compiler to emit relocations for unaligned data.
+ * We handle this situation with these inlines.
+ */
+#define	RELOC_ALIGNED_P(x) \


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define RELOC_ALIGNED_P(x) \

#define RELOC_ALIGNED_P(x) \

github-actions · 2024-01-30T16:07:15Z

ld.elf_so/arch/arm/mdreloc.c

+int
+_rtld_relocate_nonplt_objects(Obj_Entry *obj)


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

int

_rtld_relocate_nonplt_objects(Obj_Entry *obj)

int _rtld_relocate_nonplt_objects(Obj_Entry *obj)

github-actions · 2024-01-30T16:07:15Z

ld.elf_so/arch/arm/mdreloc.c

+		Elf_Addr        *where;
+		Elf_Addr         tmp;
+		unsigned long	 symnum;


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

Elf_Addr *where;

Elf_Addr tmp;

unsigned long symnum;

Elf_Addr *where;

Elf_Addr tmp;

unsigned long symnum;

github-actions · 2024-01-30T16:07:15Z

ld.elf_so/arch/arm/mdreloc.c

+		case R_TYPE(PC24):	/* word32 S - P + A */
+		case R_TYPE(ABS32):	/* word32 B + S + A */
+		case R_TYPE(GLOB_DAT):	/* word32 B + S */
+		case R_TYPE(TLS_DTPOFF32):
+		case R_TYPE(TLS_DTPMOD32):
+		case R_TYPE(TLS_TPOFF32):
+			symnum = ELF_R_SYM(rel->r_info);
+			if (last_symnum != symnum) {
+				last_symnum = symnum;
+				def = _rtld_find_symdef(symnum, obj, &defobj,
+				    false);
+				if (def == NULL)


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

case R_TYPE(PC24): /* word32 S - P + A */

case R_TYPE(ABS32): /* word32 B + S + A */

case R_TYPE(GLOB_DAT): /* word32 B + S */

case R_TYPE(TLS_DTPOFF32):

case R_TYPE(TLS_DTPMOD32):

case R_TYPE(TLS_TPOFF32):

symnum = ELF_R_SYM(rel->r_info);

if (last_symnum != symnum) {

last_symnum = symnum;

def = _rtld_find_symdef(symnum, obj, &defobj,

false);

if (def == NULL)

case R_TYPE(PC24): /* word32 S - P + A */

case R_TYPE(ABS32): /* word32 B + S + A */

case R_TYPE(GLOB_DAT): /* word32 B + S */

case R_TYPE(TLS_DTPOFF32):

case R_TYPE(TLS_DTPMOD32):

case R_TYPE(TLS_TPOFF32):

symnum = ELF_R_SYM(rel->r_info);

if (last_symnum != symnum) {

last_symnum = symnum;

def = _rtld_find_symdef(symnum, obj, &defobj,

false);

if (def == NULL)

return -1;

}

break;

default:

break;

}

switch (ELF_R_TYPE(rel->r_info)) {

case R_TYPE(NONE):

break;

#if 1 /* XXX should not occur */

case R_TYPE(PC24): { /* word32 S - P + A */

Elf32_Sword addend;

/*

* Extract addend and sign-extend if needed.

*/

addend = *where;

if (addend & 0x00800000)

addend |= 0xff000000;

tmp = (Elf_Addr)obj->relocbase + def->st_value - (Elf_Addr)where + (addend << 2);

if ((tmp & 0xfe000000) != 0xfe000000 &&

(tmp & 0xfe000000) != 0) {

_rtld_error(

"%s: R_ARM_PC24 relocation @ %p to %s failed "

"(displacement %ld (%#lx) out of range)",

obj->path, where,

obj->strtab + obj->symtab[ELF_R_SYM(rel->r_info)].st_name,

(long)tmp, (long)tmp);

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

clang-format-pr

github-actions · 2024-01-30T18:59:25Z

ld.elf_so/arch/arm/mdreloc.c

+				    false);
+				if (def == NULL)
+					return -1;
+			}


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

}

}

tmp >>= 2;

*where = (*where & 0xff000000) | (tmp & 0x00ffffff);

rdbg(("PC24 %s in %s --> %p @ %p in %s",

obj->strtab + obj->symtab[ELF_R_SYM(rel->r_info)].st_name, obj->path, (void *)*where, where,

defobj->path));

break;

}

github-actions · 2024-01-30T18:59:25Z

ld.elf_so/arch/arm/mdreloc.c

+			break;
+
+		default:
+			break;


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

break;

default:

break;

#endif

case R_TYPE(ABS32): /* word32 B + S + A */

case R_TYPE(GLOB_DAT): /* word32 B + S */

if (__predict_true(RELOC_ALIGNED_P(where))) {

tmp = *where + (Elf_Addr)defobj->relocbase +

def->st_value;

/* Set the Thumb bit, if needed. */

if (ELF_ST_TYPE(def->st_info) == STT_ARM_TFUNC)

tmp |= 1;

*where = tmp;

}

else {

tmp = load_ptr(where) +

(Elf_Addr)defobj->relocbase +

def->st_value;

/* Set the Thumb bit, if needed. */

if (ELF_ST_TYPE(def->st_info) == STT_ARM_TFUNC)

tmp |= 1;

store_ptr(where, tmp);

}

rdbg(("ABS32/GLOB_DAT %s in %s --> %p @ %p in %s",

obj->strtab + obj->symtab[ELF_R_SYM(rel->r_info)].st_name, obj->path, (void *)tmp, where,

defobj->path));

break;

case R_TYPE(IRELATIVE):

/* IFUNC relocations are handled in _rtld_call_ifunc */

if (obj->ifunc_remaining_nonplt == 0)

obj->ifunc_remaining_nonplt = obj->rellim - rel;

/* FALL-THROUGH */

case R_TYPE(RELATIVE): /* word32 B + A */

if (__predict_true(RELOC_ALIGNED_P(where))) {

tmp = *where + (Elf_Addr)obj->relocbase;

*where = tmp;

}

else {

tmp = load_ptr(where) +

(Elf_Addr)obj->relocbase;

store_ptr(where, tmp);

}

rdbg(("RELATIVE in %s --> %p", obj->path,

(void *)tmp));

break;

case R_TYPE(COPY):

/*

* These are deferred until all other relocations have

* been done. All we do here is make sure that the

* COPY relocation is not in a shared library. They

* are allowed only in executable files.

*/

if (obj->isdynamic) {

_rtld_error(

"%s: Unexpected R_COPY relocation in shared library",

obj->path);

return -1;

}

rdbg(("COPY (avoid in main)"));

break;

case R_TYPE(TLS_DTPOFF32):

tmp = (Elf_Addr)(def->st_value);

if (__predict_true(RELOC_ALIGNED_P(where)))

*where = tmp;

else

store_ptr(where, tmp);

rdbg(("TLS_DTPOFF32 %s in %s --> %p",

obj->strtab + obj->symtab[ELF_R_SYM(rel->r_info)].st_name, obj->path, (void *)tmp));

break;

case R_TYPE(TLS_DTPMOD32):

tmp = (Elf_Addr)(defobj->tlsindex);

if (__predict_true(RELOC_ALIGNED_P(where)))

*where = tmp;

else

store_ptr(where, tmp);

rdbg(("TLS_DTPMOD32 %s in %s --> %p",

obj->strtab + obj->symtab[ELF_R_SYM(rel->r_info)].st_name, obj->path, (void *)tmp));

break;

case R_TYPE(TLS_TPOFF32):

if (!defobj->tls_static &&

_rtld_tls_offset_allocate(__UNCONST(defobj)))

return -1;

if (__predict_true(RELOC_ALIGNED_P(where)))

tmp = *where;

else

tmp = load_ptr(where);

tmp += (Elf_Addr)def->st_value + defobj->tlsoffset + sizeof(struct tls_tcb);

if (__predict_true(RELOC_ALIGNED_P(where)))

*where = tmp;

else

store_ptr(where, tmp);

rdbg(("TLS_TPOFF32 %s in %s --> %p",

obj->strtab + obj->symtab[ELF_R_SYM(rel->r_info)].st_name, obj->path, (void *)tmp));

break;

default:

rdbg(("sym = %lu, type = %lu, offset = %p, "

"contents = %p",

(u_long)ELF_R_SYM(rel->r_info),

(u_long)ELF_R_TYPE(rel->r_info),

(void *)rel->r_offset, (void *)load_ptr(where)));

_rtld_error("%s: Unsupported relocation type %ld "

"in non-PLT relocations",

obj->path, (u_long)ELF_R_TYPE(rel->r_info));

return -1;

github-actions · 2024-01-30T18:59:26Z

ld.elf_so/arch/arm/mdreloc.c

+				if (ELF_ST_TYPE(def->st_info) == STT_ARM_TFUNC)
+				    tmp |= 1;
+				store_ptr(where, tmp);
+			}
+			rdbg(("ABS32/GLOB_DAT %s in %s --> %p @ %p in %s",
+			    obj->strtab + obj->symtab[ELF_R_SYM(rel->r_info)]
+			    .st_name, obj->path, (void *)tmp, where,
+			    defobj->path));
+			break;
+
+		case R_TYPE(IRELATIVE):
+			/* IFUNC relocations are handled in _rtld_call_ifunc */
+			if (obj->ifunc_remaining_nonplt == 0)
+				obj->ifunc_remaining_nonplt = obj->rellim - rel;
+			/* FALL-THROUGH */
+
+		case R_TYPE(RELATIVE):	/* word32 B + A */
+			if (__predict_true(RELOC_ALIGNED_P(where))) {
+				tmp = *where + (Elf_Addr)obj->relocbase;
+				*where = tmp;
+			} else {
+				tmp = load_ptr(where) +
+				    (Elf_Addr)obj->relocbase;
+				store_ptr(where, tmp);
+			}
+			rdbg(("RELATIVE in %s --> %p", obj->path,
+			    (void *)tmp));
+			break;
+
+		case R_TYPE(COPY):
+			/*
+			 * These are deferred until all other relocations have
+			 * been done.  All we do here is make sure that the
+			 * COPY relocation is not in a shared library.  They
+			 * are allowed only in executable files.
+			 */
+			if (obj->isdynamic) {
+				_rtld_error(
+			"%s: Unexpected R_COPY relocation in shared library",
+				    obj->path);
+				return -1;
+			}
+			rdbg(("COPY (avoid in main)"));
+			break;
+
+		case R_TYPE(TLS_DTPOFF32):
+			tmp = (Elf_Addr)(def->st_value);
+			if (__predict_true(RELOC_ALIGNED_P(where)))
+				*where = tmp;
+			else
+				store_ptr(where, tmp);
+
+			rdbg(("TLS_DTPOFF32 %s in %s --> %p",
+			    obj->strtab + obj->symtab[ELF_R_SYM(rel->r_info)]
+			    .st_name, obj->path, (void *)tmp));
+
+			break;
+		case R_TYPE(TLS_DTPMOD32):
+			tmp = (Elf_Addr)(defobj->tlsindex);
+			if (__predict_true(RELOC_ALIGNED_P(where)))
+				*where = tmp;
+			else
+				store_ptr(where, tmp);
+
+			rdbg(("TLS_DTPMOD32 %s in %s --> %p",
+			    obj->strtab + obj->symtab[ELF_R_SYM(rel->r_info)]
+			    .st_name, obj->path, (void *)tmp));
+
+			break;
+
+		case R_TYPE(TLS_TPOFF32):
+			if (!defobj->tls_static &&
+			    _rtld_tls_offset_allocate(__UNCONST(defobj)))
+				return -1;
+
+			if (__predict_true(RELOC_ALIGNED_P(where)))
+				tmp = *where;
+			else
+				tmp = load_ptr(where);
+			tmp += (Elf_Addr)def->st_value + defobj->tlsoffset + sizeof(struct tls_tcb);
+			if (__predict_true(RELOC_ALIGNED_P(where)))
+				*where = tmp;
+			else
+				store_ptr(where, tmp);
+			rdbg(("TLS_TPOFF32 %s in %s --> %p",
+			    obj->strtab + obj->symtab[ELF_R_SYM(rel->r_info)]
+			    .st_name, obj->path, (void *)tmp));
+			break;
+
+		default:
+			rdbg(("sym = %lu, type = %lu, offset = %p, "
+			    "contents = %p",
+			    (u_long)ELF_R_SYM(rel->r_info),
+			    (u_long)ELF_R_TYPE(rel->r_info),
+			    (void *)rel->r_offset, (void *)load_ptr(where)));
+			_rtld_error("%s: Unsupported relocation type %ld "
+			    "in non-PLT relocations",
+			    obj->path, (u_long) ELF_R_TYPE(rel->r_info));
+			return -1;
+		}


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

switch (ELF_R_TYPE(rel->r_info)) {

case R_TYPE(NONE):

break;

#if 1 /* XXX should not occur */

case R_TYPE(PC24): { /* word32 S - P + A */

Elf32_Sword addend;

/*

* Extract addend and sign-extend if needed.

*/

addend = *where;

if (addend & 0x00800000)

addend |= 0xff000000;

tmp = (Elf_Addr)obj->relocbase + def->st_value

- (Elf_Addr)where + (addend << 2);

if ((tmp & 0xfe000000) != 0xfe000000 &&

(tmp & 0xfe000000) != 0) {

_rtld_error(

"%s: R_ARM_PC24 relocation @ %p to %s failed "

"(displacement %ld (%#lx) out of range)",

obj->path, where,

obj->strtab + obj->symtab[

ELF_R_SYM(rel->r_info)].st_name,

(long) tmp, (long) tmp);

return -1;

}

tmp >>= 2;

*where = (*where & 0xff000000) | (tmp & 0x00ffffff);

rdbg(("PC24 %s in %s --> %p @ %p in %s",

obj->strtab + obj->symtab[ELF_R_SYM(rel->r_info)]

.st_name, obj->path, (void *)*where, where,

defobj->path));

break;

}

#endif

case R_TYPE(ABS32): /* word32 B + S + A */

case R_TYPE(GLOB_DAT): /* word32 B + S */

if (__predict_true(RELOC_ALIGNED_P(where))) {

tmp = *where + (Elf_Addr)defobj->relocbase +

def->st_value;

/* Set the Thumb bit, if needed. */

if (ELF_ST_TYPE(def->st_info) == STT_ARM_TFUNC)

tmp |= 1;

*where = tmp;

} else {

tmp = load_ptr(where) +

(Elf_Addr)defobj->relocbase +

def->st_value;

/* Set the Thumb bit, if needed. */

if (ELF_ST_TYPE(def->st_info) == STT_ARM_TFUNC)

tmp |= 1;

store_ptr(where, tmp);

}

rdbg(("ABS32/GLOB_DAT %s in %s --> %p @ %p in %s",

obj->strtab + obj->symtab[ELF_R_SYM(rel->r_info)]

.st_name, obj->path, (void *)tmp, where,

defobj->path));

break;

case R_TYPE(IRELATIVE):

/* IFUNC relocations are handled in _rtld_call_ifunc */

if (obj->ifunc_remaining_nonplt == 0)

obj->ifunc_remaining_nonplt = obj->rellim - rel;

/* FALL-THROUGH */

case R_TYPE(RELATIVE): /* word32 B + A */

if (__predict_true(RELOC_ALIGNED_P(where))) {

tmp = *where + (Elf_Addr)obj->relocbase;

*where = tmp;

} else {

tmp = load_ptr(where) +

(Elf_Addr)obj->relocbase;

store_ptr(where, tmp);

}

rdbg(("RELATIVE in %s --> %p", obj->path,

(void *)tmp));

break;

case R_TYPE(COPY):

/*

* These are deferred until all other relocations have

* been done. All we do here is make sure that the

* COPY relocation is not in a shared library. They

* are allowed only in executable files.

*/

if (obj->isdynamic) {

_rtld_error(

"%s: Unexpected R_COPY relocation in shared library",

obj->path);

return -1;

}

rdbg(("COPY (avoid in main)"));

break;

case R_TYPE(TLS_DTPOFF32):

tmp = (Elf_Addr)(def->st_value);

if (__predict_true(RELOC_ALIGNED_P(where)))

*where = tmp;

else

store_ptr(where, tmp);

rdbg(("TLS_DTPOFF32 %s in %s --> %p",

obj->strtab + obj->symtab[ELF_R_SYM(rel->r_info)]

.st_name, obj->path, (void *)tmp));

break;

case R_TYPE(TLS_DTPMOD32):

tmp = (Elf_Addr)(defobj->tlsindex);

if (__predict_true(RELOC_ALIGNED_P(where)))

*where = tmp;

else

store_ptr(where, tmp);

rdbg(("TLS_DTPMOD32 %s in %s --> %p",

obj->strtab + obj->symtab[ELF_R_SYM(rel->r_info)]

.st_name, obj->path, (void *)tmp));

break;

case R_TYPE(TLS_TPOFF32):

if (!defobj->tls_static &&

_rtld_tls_offset_allocate(__UNCONST(defobj)))

return -1;

if (__predict_true(RELOC_ALIGNED_P(where)))

tmp = *where;

else

tmp = load_ptr(where);

tmp += (Elf_Addr)def->st_value + defobj->tlsoffset + sizeof(struct tls_tcb);

if (__predict_true(RELOC_ALIGNED_P(where)))

*where = tmp;

else

store_ptr(where, tmp);

rdbg(("TLS_TPOFF32 %s in %s --> %p",

obj->strtab + obj->symtab[ELF_R_SYM(rel->r_info)]

.st_name, obj->path, (void *)tmp));

break;

default:

rdbg(("sym = %lu, type = %lu, offset = %p, "

"contents = %p",

(u_long)ELF_R_SYM(rel->r_info),

(u_long)ELF_R_TYPE(rel->r_info),

(void *)rel->r_offset, (void *)load_ptr(where)));

_rtld_error("%s: Unsupported relocation type %ld "

"in non-PLT relocations",

obj->path, (u_long) ELF_R_TYPE(rel->r_info));

return -1;

}

github-actions · 2024-01-30T18:59:26Z

ld.elf_so/arch/arm/mdreloc.c

+int
+_rtld_relocate_plt_lazy(Obj_Entry *obj)


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

int

_rtld_relocate_plt_lazy(Obj_Entry *obj)

int _rtld_relocate_plt_lazy(Obj_Entry *obj)

github-actions · 2024-01-30T18:59:26Z

ld.elf_so/arch/arm/mdreloc.c

+{
+	const Elf_Rel *rel;
+
+	for (rel = obj->pltrellim; rel-- > obj->pltrel; ) {


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

for (rel = obj->pltrellim; rel-- > obj->pltrel; ) {

for (rel = obj->pltrellim; rel-- > obj->pltrel;) {

github-actions · 2024-01-30T18:59:28Z

ld.elf_so/arch/hppa/hppa_reloc.c

+static SLIST_HEAD(hppa_plabel_head, _hppa_plabel) hppa_plabel_list
+    = SLIST_HEAD_INITIALIZER(hppa_plabel_list);


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

static SLIST_HEAD(hppa_plabel_head, _hppa_plabel) hppa_plabel_list

= SLIST_HEAD_INITIALIZER(hppa_plabel_list);

static SLIST_HEAD(hppa_plabel_head, _hppa_plabel) hppa_plabel_list = SLIST_HEAD_INITIALIZER(hppa_plabel_list);

github-actions · 2024-01-30T18:59:28Z

ld.elf_so/arch/hppa/hppa_reloc.c

+ * Because I'm hesitant to use NEW while relocating self,
+ * this is a small pool of preallocated PLABELs.
+ */
+#define	HPPA_PLABEL_PRE	(32)


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define HPPA_PLABEL_PRE (32)

#define HPPA_PLABEL_PRE (32)

github-actions · 2024-01-30T18:59:28Z

ld.elf_so/arch/hppa/hppa_reloc.c

+void _rtld_relocate_nonplt_self(Elf_Dyn *, Elf_Addr);
+int _rtld_relocate_plt_objects(const Obj_Entry *);
+static inline int _rtld_relocate_plt_object(const Obj_Entry *,
+    const Elf_Rela *, Elf_Addr *);


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

const Elf_Rela *, Elf_Addr *);

const Elf_Rela *, Elf_Addr *);

github-actions · 2024-01-30T18:59:28Z

ld.elf_so/arch/hppa/hppa_reloc.c

+void
+_rtld_relocate_nonplt_self(Elf_Dyn *dynp, Elf_Addr relocbase)
+{
+	const Elf_Rela	*relafirst, *rela, *relalim;
+	Elf_Addr        relasz;
+	void		*where;
+	Elf_Addr	*pltgot;
+	const Elf_Rela	*plabel_relocs[HPPA_PLABEL_PRE];
+	int		nplabel_relocs = 0;
+	int		i;
+	const Elf_Sym	*symtab, *sym;
+	unsigned long	symnum;
+	hppa_plabel	*plabel;


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

void

_rtld_relocate_nonplt_self(Elf_Dyn *dynp, Elf_Addr relocbase)

{

const Elf_Rela *relafirst, *rela, *relalim;

Elf_Addr relasz;

void *where;

Elf_Addr *pltgot;

const Elf_Rela *plabel_relocs[HPPA_PLABEL_PRE];

int nplabel_relocs = 0;

int i;

const Elf_Sym *symtab, *sym;

unsigned long symnum;

hppa_plabel *plabel;

void _rtld_relocate_nonplt_self(Elf_Dyn *dynp, Elf_Addr relocbase)

{

const Elf_Rela *relafirst, *rela, *relalim;

Elf_Addr relasz;

void *where;

Elf_Addr *pltgot;

const Elf_Rela *plabel_relocs[HPPA_PLABEL_PRE];

int nplabel_relocs = 0;

int i;

const Elf_Sym *symtab, *sym;

unsigned long symnum;

hppa_plabel *plabel;

github-actions · 2024-01-30T18:59:28Z

ld.elf_so/arch/hppa/hppa_reloc.c

+		case DT_RELA:
+			relafirst = (const Elf_Rela *)
+			    (relocbase + dynp->d_un.d_ptr);
+			break;
+
+		case DT_RELASZ:
+			relasz = dynp->d_un.d_val;
+			break;
+
+		case DT_SYMTAB:
+			symtab = (const Elf_Sym *)
+			    (relocbase + dynp->d_un.d_ptr);
+			break;
+
+		case DT_PLTGOT:
+			pltgot = (Elf_Addr *)
+			    (relocbase + dynp->d_un.d_ptr);
+			break;


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

case DT_RELA:

relafirst = (const Elf_Rela *)

(relocbase + dynp->d_un.d_ptr);

break;

case DT_RELASZ:

relasz = dynp->d_un.d_val;

break;

case DT_SYMTAB:

symtab = (const Elf_Sym *)

(relocbase + dynp->d_un.d_ptr);

break;

case DT_PLTGOT:

pltgot = (Elf_Addr *)

(relocbase + dynp->d_un.d_ptr);

break;

case DT_RELA:

relafirst = (const Elf_Rela *)(relocbase + dynp->d_un.d_ptr);

break;

case DT_RELASZ:

relasz = dynp->d_un.d_val;

break;

case DT_SYMTAB:

symtab = (const Elf_Sym *)(relocbase + dynp->d_un.d_ptr);

break;

case DT_PLTGOT:

pltgot = (Elf_Addr *)(relocbase + dynp->d_un.d_ptr);

break;

github-actions · 2024-01-31T14:26:16Z

ld.elf_so/NetBSD/cdefs.h

+ *
+ *	* These are meant to be used in places that are run `a lot'.
+ *	  It is wasteful to make predictions in code that is run
+ *	  seldomly (e.g. at subsystem initialization time) as the


[codespell] _{reported by reviewdog 🐶}
seldomly ==> seldom

github-actions · 2024-01-31T14:26:16Z

ld.elf_so/NetBSD/exec_elf.h

+#define EM_CLOUDSHIELD	192	/* CloudShield architecture family */
+#define EM_COREA_1ST	193	/* KIPO-KAIST Core-A 1st generation processor family */
+#define EM_COREA_2ND	194	/* KIPO-KAIST Core-A 2nd generation processor family */
+#define EM_ARC_COMPACT2	195	/* Synopsys ARCompact V2 */


[codespell] _{reported by reviewdog 🐶}
Synopsys ==> Synopsis

github-actions · 2024-01-31T14:26:16Z

ld.elf_so/NetBSD/exec_elf.h

+#define SHF_MASKOS	     0x0ff00000 /* Operating system specific values */
+#define SHF_MASKPROC	     0xf0000000 /* Processor-specific values */
+#define SHF_ORDERED	     0x40000000 /* Ordering requirement (Solaris) */
+#define SHF_EXCLUDE	     0x80000000 /* Excluded unless unles ref/alloc


[codespell] _{reported by reviewdog 🐶}
unles ==> unless

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

clang-format-pr

github-actions · 2024-01-31T14:26:15Z

ld.elf_so/NetBSD/arch/i386/elf_machdep.h

+#define	ELF32_MACHDEP_ENDIANNESS	ELFDATA2LSB
+#define	ELF32_MACHDEP_ID_CASES						\
+		case EM_386:						\
+		case EM_486:						\
+			break;


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define ELF32_MACHDEP_ENDIANNESS ELFDATA2LSB

#define ELF32_MACHDEP_ID_CASES \

case EM_386: \

case EM_486: \

break;

#define ELF32_MACHDEP_ENDIANNESS ELFDATA2LSB

#define ELF32_MACHDEP_ID_CASES \

case EM_386: \

case EM_486: \

break;

github-actions · 2024-01-31T14:26:15Z

ld.elf_so/NetBSD/arch/i386/elf_machdep.h

+#define	ELF64_MACHDEP_ENDIANNESS	XXX	/* break compilation */
+#define	ELF64_MACHDEP_ID_CASES						\
+		/* no 64-bit ELF machine types supported */


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define ELF64_MACHDEP_ENDIANNESS XXX /* break compilation */

#define ELF64_MACHDEP_ID_CASES \

/* no 64-bit ELF machine types supported */

#define ELF64_MACHDEP_ENDIANNESS XXX /* break compilation */

#define ELF64_MACHDEP_ID_CASES \

/* no 64-bit ELF machine types supported */

github-actions · 2024-01-31T14:26:15Z

ld.elf_so/NetBSD/arch/i386/elf_machdep.h

+#define	ELF64_MACHDEP_ID_CASES						\
+		/* no 64-bit ELF machine types supported */
+
+#define	ELF32_MACHDEP_ID		EM_386


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define ELF32_MACHDEP_ID EM_386

#define ELF32_MACHDEP_ID EM_386

github-actions · 2024-01-31T14:26:16Z

ld.elf_so/NetBSD/arch/i386/elf_machdep.h

+#define	KERN_ELFSIZE		32
+#define ARCH_ELFSIZE		32	/* MD native binary size */


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define KERN_ELFSIZE 32

#define ARCH_ELFSIZE 32 /* MD native binary size */

#define KERN_ELFSIZE 32

#define ARCH_ELFSIZE 32 /* MD native binary size */

github-actions · 2024-01-31T14:26:16Z

ld.elf_so/NetBSD/arch/i386/elf_machdep.h

+#define	R_386_NONE	0
+#define	R_386_32	1
+#define	R_386_PC32	2
+#define	R_386_GOT32	3
+#define	R_386_PLT32	4
+#define	R_386_COPY	5
+#define	R_386_GLOB_DAT	6
+#define	R_386_JMP_SLOT	7
+#define	R_386_RELATIVE	8
+#define	R_386_GOTOFF	9
+#define	R_386_GOTPC	10
+#define	R_386_32PLT	11


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define R_386_NONE 0

#define R_386_32 1

#define R_386_PC32 2

#define R_386_GOT32 3

#define R_386_PLT32 4

#define R_386_COPY 5

#define R_386_GLOB_DAT 6

#define R_386_JMP_SLOT 7

#define R_386_RELATIVE 8

#define R_386_GOTOFF 9

#define R_386_GOTPC 10

#define R_386_32PLT 11

#define R_386_NONE 0

#define R_386_32 1

#define R_386_PC32 2

#define R_386_GOT32 3

#define R_386_PLT32 4

#define R_386_COPY 5

#define R_386_GLOB_DAT 6

#define R_386_JMP_SLOT 7

#define R_386_RELATIVE 8

#define R_386_GOTOFF 9

#define R_386_GOTPC 10

#define R_386_32PLT 11

github-actions · 2024-01-31T14:26:18Z

ld.elf_so/NetBSD/bitops.h

+#define	__BITMAP_ZERO(__v) \
+    (void)__builtin_memset((__v), 0, sizeof(*__v))


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define __BITMAP_ZERO(__v) \

(void)__builtin_memset((__v), 0, sizeof(*__v))

#define __BITMAP_ZERO(__v) \

(void)__builtin_memset((__v), 0, sizeof(*__v))

github-actions · 2024-01-31T14:26:18Z

ld.elf_so/NetBSD/bitops.h

+#define __BITMAP_ZERO(__v) do {						\
+	size_t __i;							\
+	for (__i = 0; __i < __arraycount((__v)->_b); __i++)		\
+		(__v)->_b[__i] = 0;					\


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define __BITMAP_ZERO(__v) do { \

size_t __i; \

for (__i = 0; __i < __arraycount((__v)->_b); __i++) \

(__v)->_b[__i] = 0; \

#define __BITMAP_ZERO(__v) \

do { \

size_t __i; \

for (__i = 0; __i < __arraycount((__v)->_b); __i++) \

(__v)->_b[__i] = 0; \

github-actions · 2024-01-31T14:26:18Z

ld.elf_so/NetBSD/cdefs.h

+#ifndef	_SYS_CDEFS_H_
+#define	_SYS_CDEFS_H_


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#ifndef _SYS_CDEFS_H_

#define _SYS_CDEFS_H_

#ifndef _SYS_CDEFS_H_

#define _SYS_CDEFS_H_

github-actions · 2024-01-31T14:26:18Z

ld.elf_so/NetBSD/cdefs.h

+#define	__GNUC_PREREQ__(x, y)						\
+	((__GNUC__ == (x) && __GNUC_MINOR__ >= (y)) ||			\
+	 (__GNUC__ > (x)))
+#else
+#define	__GNUC_PREREQ__(x, y)	0


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define __GNUC_PREREQ__(x, y) \

((__GNUC__ == (x) && __GNUC_MINOR__ >= (y)) || \

(__GNUC__ > (x)))

#else

#define __GNUC_PREREQ__(x, y) 0

#define __GNUC_PREREQ__(x, y) \

((__GNUC__ == (x) && __GNUC_MINOR__ >= (y)) || \

(__GNUC__ > (x)))

#else

#define __GNUC_PREREQ__(x, y) 0

github-actions · 2024-01-31T14:26:18Z

ld.elf_so/NetBSD/cdefs.h

+ *	#endif
+ */
+#ifndef __has_feature
+#define __has_feature(x)	0


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define __has_feature(x) 0

#define __has_feature(x) 0

badochov · 2024-01-31T15:09:38Z

@agkaminski When it comes to formatting indent one available on linux has different options to one distributed by NetBSD so some porting will be needed

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

clang-format-pr

github-actions · 2024-02-01T13:17:23Z

ld.elf_so/NetBSD/cdefs.h

+#endif
+
+#ifndef __has_extension
+#define __has_extension		__has_feature /* Compat with pre-3.0 Clang */


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define __has_extension __has_feature /* Compat with pre-3.0 Clang */

#define __has_extension __has_feature /* Compat with pre-3.0 Clang */

github-actions · 2024-02-01T13:17:23Z

ld.elf_so/NetBSD/cdefs.h

+#define	__strict_weak_alias(alias,sym)					\
+	__unused static __typeof__(alias) *__weak_alias_##alias = &sym;	\
+	__weak_alias(alias,sym)
+#else
+#define	__strict_weak_alias(alias,sym) __weak_alias(alias,sym)


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define __strict_weak_alias(alias,sym) \

__unused static __typeof__(alias) *__weak_alias_##alias = &sym; \

__weak_alias(alias,sym)

#else

#define __strict_weak_alias(alias,sym) __weak_alias(alias,sym)

#define __strict_weak_alias(alias, sym) \

__unused static __typeof__(alias) *__weak_alias_##alias = &sym; \

__weak_alias(alias, sym)

#else

#define __strict_weak_alias(alias, sym) __weak_alias(alias, sym)

github-actions · 2024-02-01T13:17:23Z

ld.elf_so/NetBSD/cdefs.h

+ * Optional marker for size-optimised MD calling convention.
+ */
+#ifndef __compactcall
+#define	__compactcall


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define __compactcall

#define __compactcall

github-actions · 2024-02-01T13:17:23Z

ld.elf_so/NetBSD/cdefs.h

+#define	___STRING(x)	__STRING(x)
+#define	___CONCAT(x,y)	__CONCAT(x,y)


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define ___STRING(x) __STRING(x)

#define ___CONCAT(x,y) __CONCAT(x,y)

#define ___STRING(x) __STRING(x)

#define ___CONCAT(x, y) __CONCAT(x, y)

github-actions · 2024-02-01T13:17:23Z

ld.elf_so/NetBSD/cdefs.h

+#define	__P(protos)	protos		/* full-blown ANSI C */
+#define	__CONCAT(x,y)	x ## y
+#define	__STRING(x)	#x
+
+#define	__const		const		/* define reserved names to standard */
+#define	__signed	signed
+#define	__volatile	volatile
+
+#define	__CONCAT3(a,b,c)		a ## b ## c
+#define	__CONCAT4(a,b,c,d)		a ## b ## c ## d
+#define	__CONCAT5(a,b,c,d,e)		a ## b ## c ## d ## e
+#define	__CONCAT6(a,b,c,d,e,f)		a ## b ## c ## d ## e ## f
+#define	__CONCAT7(a,b,c,d,e,f,g)	a ## b ## c ## d ## e ## f ## g
+#define	__CONCAT8(a,b,c,d,e,f,g,h)	a ## b ## c ## d ## e ## f ## g ## h


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define __P(protos) protos /* full-blown ANSI C */

#define __CONCAT(x,y) x ## y

#define __STRING(x) #x

#define __const const /* define reserved names to standard */

#define __signed signed

#define __volatile volatile

#define __CONCAT3(a,b,c) a ## b ## c

#define __CONCAT4(a,b,c,d) a ## b ## c ## d

#define __CONCAT5(a,b,c,d,e) a ## b ## c ## d ## e

#define __CONCAT6(a,b,c,d,e,f) a ## b ## c ## d ## e ## f

#define __CONCAT7(a,b,c,d,e,f,g) a ## b ## c ## d ## e ## f ## g

#define __CONCAT8(a,b,c,d,e,f,g,h) a ## b ## c ## d ## e ## f ## g ## h

#define __P(protos) protos /* full-blown ANSI C */

#define __CONCAT(x, y) x##y

#define __STRING(x) #x

#define __const const /* define reserved names to standard */

#define __signed signed

#define __volatile volatile

#define __CONCAT3(a, b, c) a##b##c

#define __CONCAT4(a, b, c, d) a##b##c##d

#define __CONCAT5(a, b, c, d, e) a##b##c##d##e

#define __CONCAT6(a, b, c, d, e, f) a##b##c##d##e##f

#define __CONCAT7(a, b, c, d, e, f, g) a##b##c##d##e##f##g

#define __CONCAT8(a, b, c, d, e, f, g, h) a##b##c##d##e##f##g##h

github-actions · 2024-02-01T13:17:26Z

ld.elf_so/NetBSD/cdefs.h

+#define	__noclone	__attribute__((__noclone__))
+#else
+#define	__noclone	/* nothing */


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define __noclone __attribute__((__noclone__))

#else

#define __noclone /* nothing */

#define __noclone __attribute__((__noclone__))

#else

#define __noclone /* nothing */

github-actions · 2024-02-01T13:17:26Z

ld.elf_so/NetBSD/cdefs.h

+#define	__unused	__attribute__((__unused__))
+#else
+#define	__unused	/* delete */


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define __unused __attribute__((__unused__))

#else

#define __unused /* delete */

#define __unused __attribute__((__unused__))

#else

#define __unused /* delete */

github-actions · 2024-02-01T13:17:26Z

ld.elf_so/NetBSD/cdefs.h

+#define	__used		__attribute__((__used__))
+#else
+#define	__used		__unused


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define __used __attribute__((__used__))

#else

#define __used __unused

#define __used __attribute__((__used__))

#else

#define __used __unused

github-actions · 2024-02-01T13:17:26Z

ld.elf_so/NetBSD/cdefs.h

+#if (defined(_KERNEL) && defined(DIAGNOSTIC)) \
+ || (!defined(_KERNEL) && !defined(NDEBUG))
+#define	__diagused	/* empty */
+#else
+#define	__diagused	__unused


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#if (defined(_KERNEL) && defined(DIAGNOSTIC)) \

|| (!defined(_KERNEL) && !defined(NDEBUG))

#define __diagused /* empty */

#else

#define __diagused __unused

#if (defined(_KERNEL) && defined(DIAGNOSTIC)) || (!defined(_KERNEL) && !defined(NDEBUG))

#define __diagused /* empty */

#else

#define __diagused __unused

github-actions · 2024-02-01T13:17:26Z

ld.elf_so/NetBSD/cdefs.h

+#define	__debugused	/* empty */
+#else
+#define	__debugused	__unused


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define __debugused /* empty */

#else

#define __debugused __unused

#define __debugused /* empty */

#else

#define __debugused __unused

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

clang-format-pr

github-actions · 2024-02-02T13:01:08Z

ld.elf_so/NetBSD/cdefs.h

+#define	__noprofile	__attribute__((__no_instrument_function__))
+#else
+#define	__noprofile	/* nothing */


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define __noprofile __attribute__((__no_instrument_function__))

#else

#define __noprofile /* nothing */

#define __noprofile __attribute__((__no_instrument_function__))

#else

#define __noprofile /* nothing */

github-actions · 2024-02-02T13:01:09Z

ld.elf_so/NetBSD/cdefs.h

+#define	__unreachable()	__builtin_unreachable()
+#else
+#define	__unreachable()	do {} while (/*CONSTCOND*/0)


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define __unreachable() __builtin_unreachable()

#else

#define __unreachable() do {} while (/*CONSTCOND*/0)

#define __unreachable() __builtin_unreachable()

#else

#define __unreachable() \

do { \

} while (/*CONSTCOND*/ 0)

github-actions · 2024-02-02T13:01:09Z

ld.elf_so/NetBSD/cdefs.h

+
+#if defined(_KERNEL) || defined(_RUMPKERNEL)
+#if defined(__clang__) && __has_feature(address_sanitizer)
+#define	__noasan	__attribute__((no_sanitize("kernel-address", "address")))


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define __noasan __attribute__((no_sanitize("kernel-address", "address")))

#define __noasan __attribute__((no_sanitize("kernel-address", "address")))

github-actions · 2024-02-02T13:01:09Z

ld.elf_so/NetBSD/cdefs.h

+#define	__noasan	__attribute__((no_sanitize_address))
+#else
+#define	__noasan	/* nothing */


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define __noasan __attribute__((no_sanitize_address))

#else

#define __noasan /* nothing */

#define __noasan __attribute__((no_sanitize_address))

#else

#define __noasan /* nothing */

github-actions · 2024-02-02T13:01:09Z

ld.elf_so/NetBSD/cdefs.h

+#endif
+
+#if defined(__clang__) && __has_feature(thread_sanitizer)
+#define	__nocsan	__attribute__((no_sanitize("thread")))


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define __nocsan __attribute__((no_sanitize("thread")))

#define __nocsan __attribute__((no_sanitize("thread")))

github-actions · 2024-02-02T13:01:10Z

ld.elf_so/NetBSD/cdefs.h

+
+#if !defined(_STANDALONE) && !defined(_KERNEL)
+#if defined(__GNUC__) || defined(__PCC__)
+#define	__RENAME(x)	___RENAME(x)


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define __RENAME(x) ___RENAME(x)

#define __RENAME(x) ___RENAME(x)

github-actions · 2024-02-02T13:01:10Z

ld.elf_so/NetBSD/cdefs.h

+#if defined(__GNUC__) || defined(__PCC__)
+#define	__RENAME(x)	___RENAME(x)
+#elif defined(__lint__)
+#define	__RENAME(x)	__symbolrename(x)


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define __RENAME(x) __symbolrename(x)

#define __RENAME(x) __symbolrename(x)

github-actions · 2024-02-02T13:01:10Z

ld.elf_so/NetBSD/cdefs.h

+#else /* _STANDALONE || _KERNEL */
+#define	__RENAME(x)	no renaming in kernel/standalone environment


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#else /* _STANDALONE || _KERNEL */

#define __RENAME(x) no renaming in kernel/standalone environment

#else /* _STANDALONE || _KERNEL */

#define __RENAME(x) no renaming in kernel / standalone environment

github-actions · 2024-02-02T13:01:11Z

ld.elf_so/NetBSD/cdefs.h

+#define	__insn_barrier()	__asm __volatile("":::"memory")
+#else
+#define	__insn_barrier()	/* */


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define __insn_barrier() __asm __volatile("":::"memory")

#else

#define __insn_barrier() /* */

#define __insn_barrier() __asm __volatile("" :: \

: "memory")

#else

#define __insn_barrier() /* */

github-actions · 2024-02-02T13:01:11Z

ld.elf_so/NetBSD/cdefs.h

+#define	__predict_true(exp)	__builtin_expect((exp) != 0, 1)
+#define	__predict_false(exp)	__builtin_expect((exp) != 0, 0)
+#else
+#define	__predict_true(exp)	(exp)
+#define	__predict_false(exp)	(exp)


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define __predict_true(exp) __builtin_expect((exp) != 0, 1)

#define __predict_false(exp) __builtin_expect((exp) != 0, 0)

#else

#define __predict_true(exp) (exp)

#define __predict_false(exp) (exp)

#define __predict_true(exp) __builtin_expect((exp) != 0, 1)

#define __predict_false(exp) __builtin_expect((exp) != 0, 0)

#else

#define __predict_true(exp) (exp)

#define __predict_false(exp) (exp)

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

clang-format-pr

github-actions · 2024-02-02T14:25:44Z

ld.elf_so/NetBSD/cdefs.h

+#define __printflike(fmtarg, firstvararg)	\
+	    __attribute__((__format__ (__printf__, fmtarg, firstvararg)))


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define __printflike(fmtarg, firstvararg) \

__attribute__((__format__ (__printf__, fmtarg, firstvararg)))

#define __printflike(fmtarg, firstvararg) \

__attribute__((__format__(__printf__, fmtarg, firstvararg)))

github-actions · 2024-02-02T14:25:44Z

ld.elf_so/NetBSD/cdefs.h

+#define __sysloglike(fmtarg, firstvararg)	\
+	    __attribute__((__format__ (__syslog__, fmtarg, firstvararg)))
+#define __scanflike(fmtarg, firstvararg)	\
+	    __attribute__((__format__ (__scanf__, fmtarg, firstvararg)))
+#define __format_arg(fmtarg)    __attribute__((__format_arg__ (fmtarg)))
+#else
+#define __printflike(fmtarg, firstvararg)	/* nothing */
+#define __scanflike(fmtarg, firstvararg)	/* nothing */
+#define __sysloglike(fmtarg, firstvararg)	/* nothing */
+#define __format_arg(fmtarg)			/* nothing */


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define __sysloglike(fmtarg, firstvararg) \

__attribute__((__format__ (__syslog__, fmtarg, firstvararg)))

#define __scanflike(fmtarg, firstvararg) \

__attribute__((__format__ (__scanf__, fmtarg, firstvararg)))

#define __format_arg(fmtarg) __attribute__((__format_arg__ (fmtarg)))

#else

#define __printflike(fmtarg, firstvararg) /* nothing */

#define __scanflike(fmtarg, firstvararg) /* nothing */

#define __sysloglike(fmtarg, firstvararg) /* nothing */

#define __format_arg(fmtarg) /* nothing */

#define __sysloglike(fmtarg, firstvararg) \

__attribute__((__format__(__syslog__, fmtarg, firstvararg)))

#define __scanflike(fmtarg, firstvararg) \

__attribute__((__format__(__scanf__, fmtarg, firstvararg)))

#define __format_arg(fmtarg) __attribute__((__format_arg__(fmtarg)))

#else

#define __printflike(fmtarg, firstvararg) /* nothing */

#define __scanflike(fmtarg, firstvararg) /* nothing */

#define __sysloglike(fmtarg, firstvararg) /* nothing */

#define __format_arg(fmtarg) /* nothing */

github-actions · 2024-02-02T14:25:44Z

ld.elf_so/NetBSD/cdefs.h

+ *	__link_set_entry(set, idx)
+ *		Access the link set entry at index `idx' from set `set'.
+ */
+#define	__link_set_foreach(pvar, set)					\


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define __link_set_foreach(pvar, set) \

#define __link_set_foreach(pvar, set) \

github-actions · 2024-02-02T14:25:44Z

ld.elf_so/NetBSD/cdefs.h

+#define	__link_set_foreach(pvar, set)					\
+	for (pvar = __link_set_start(set); pvar < __link_set_end(set); pvar++)
+
+#define	__link_set_entry(set, idx)	(__link_set_start(set)[idx])


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define __link_set_entry(set, idx) (__link_set_start(set)[idx])

#define __link_set_entry(set, idx) (__link_set_start(set)[idx])

github-actions · 2024-02-02T14:25:44Z

ld.elf_so/NetBSD/cdefs.h

+ * Return the natural alignment in bytes for the given type
+ */
+#if __GNUC_PREREQ__(4, 1) || defined(__lint__)
+#define	__alignof(__t)  __alignof__(__t)


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define __alignof(__t) __alignof__(__t)

#define __alignof(__t) __alignof__(__t)

github-actions · 2024-02-02T14:25:46Z

ld.elf_so/NetBSD/cdefs_elf.h

+	      ".type	" _C_LABEL_STRING(#name) ", @gnu_indirect_function\n" \
+	      _C_LABEL_STRING(#name) " = " _C_LABEL_STRING(#resolver))


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

".type " _C_LABEL_STRING(#name) ", @gnu_indirect_function\n" \

_C_LABEL_STRING(#name) " = " _C_LABEL_STRING(#resolver))

".type " _C_LABEL_STRING(#name) ", @gnu_indirect_function\n" _C_LABEL_STRING(#name) " = " _C_LABEL_STRING(#resolver))

github-actions · 2024-02-02T14:25:46Z

ld.elf_so/NetBSD/cdefs_elf.h

+	      ".hidden	" _C_LABEL_STRING(#name) "\n" \
+	      ".type	" _C_LABEL_STRING(#name) ", @gnu_indirect_function\n" \
+	      _C_LABEL_STRING(#name) " = " _C_LABEL_STRING(#resolver))


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

".hidden " _C_LABEL_STRING(#name) "\n" \

".type " _C_LABEL_STRING(#name) ", @gnu_indirect_function\n" \

_C_LABEL_STRING(#name) " = " _C_LABEL_STRING(#resolver))

".hidden " _C_LABEL_STRING(#name) "\n" \

".type " _C_LABEL_STRING(#name) ", @gnu_indirect_function\n" _C_LABEL_STRING(#name) " = " _C_LABEL_STRING(#resolver))

github-actions · 2024-02-02T14:25:46Z

ld.elf_so/NetBSD/cdefs_elf.h

+#  define	__SECTIONSTRING(_sec, _str)				\
+	__asm(".pushsection " #_sec ",\"MS\",%progbits,1\n"		\
+	      ".asciz \"" _str "\"\n"					\
+	      ".popsection")
+#else
+#  define	__SECTIONSTRING(_sec, _str)				\
+	__asm(".pushsection " _sec ",\"MS\",%progbits,1\n"		\
+	      ".asciz \"" _str "\"\n"					\
+	      ".popsection")
+#  endif
+#else
+#  if __STDC__
+#  define	__SECTIONSTRING(_sec, _str)					\
+	__asm(".pushsection " #_sec ",\"MS\",@progbits,1\n"		\
+	      ".asciz \"" _str "\"\n"					\
+	      ".popsection")
+#  else
+#  define	__SECTIONSTRING(_sec, _str)					\
+	__asm(".pushsection " _sec ",\"MS\",@progbits,1\n"		\
+	      ".asciz \"" _str "\"\n"					\
+	      ".popsection")
+#  endif
+#endif
+
+#define	__IDSTRING(_n,_s)		__SECTIONSTRING(.ident,_s)
+
+#define	__RCSID(_s)			__IDSTRING(rcsid,_s)
+#define	__SCCSID(_s)


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

# define __SECTIONSTRING(_sec, _str) \

__asm(".pushsection " #_sec ",\"MS\",%progbits,1\n" \

".asciz \"" _str "\"\n" \

".popsection")

#else

# define __SECTIONSTRING(_sec, _str) \

__asm(".pushsection " _sec ",\"MS\",%progbits,1\n" \

".asciz \"" _str "\"\n" \

".popsection")

# endif

#else

# if __STDC__

# define __SECTIONSTRING(_sec, _str) \

__asm(".pushsection " #_sec ",\"MS\",@progbits,1\n" \

".asciz \"" _str "\"\n" \

".popsection")

# else

# define __SECTIONSTRING(_sec, _str) \

__asm(".pushsection " _sec ",\"MS\",@progbits,1\n" \

".asciz \"" _str "\"\n" \

".popsection")

# endif

#endif

#define __IDSTRING(_n,_s) __SECTIONSTRING(.ident,_s)

#define __RCSID(_s) __IDSTRING(rcsid,_s)

#define __SCCSID(_s)

#define __SECTIONSTRING(_sec, _str) \

__asm(".pushsection " #_sec ",\"MS\",%progbits,1\n" \

".asciz \"" _str "\"\n" \

".popsection")

#else

#define __SECTIONSTRING(_sec, _str) \

__asm(".pushsection " _sec ",\"MS\",%progbits,1\n" \

".asciz \"" _str "\"\n" \

".popsection")

#endif

#else

#if __STDC__

#define __SECTIONSTRING(_sec, _str) \

__asm(".pushsection " #_sec ",\"MS\",@progbits,1\n" \

".asciz \"" _str "\"\n" \

".popsection")

#else

#define __SECTIONSTRING(_sec, _str) \

__asm(".pushsection " _sec ",\"MS\",@progbits,1\n" \

".asciz \"" _str "\"\n" \

".popsection")

#endif

#endif

#define __IDSTRING(_n, _s) __SECTIONSTRING(.ident, _s)

#define __RCSID(_s) __IDSTRING(rcsid, _s)

#define __SCCSID(_s)

github-actions · 2024-02-02T14:25:46Z

ld.elf_so/NetBSD/cdefs_elf.h

+#define	__COPYRIGHT(_s)			__SECTIONSTRING(.copyright,_s)
+
+#define	__KERNEL_RCSID(_n, _s)		__RCSID(_s)
+#define	__KERNEL_SCCSID(_n, _s)
+#define	__KERNEL_COPYRIGHT(_n, _s)	__COPYRIGHT(_s)


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define __COPYRIGHT(_s) __SECTIONSTRING(.copyright,_s)

#define __KERNEL_RCSID(_n, _s) __RCSID(_s)

#define __KERNEL_SCCSID(_n, _s)

#define __KERNEL_COPYRIGHT(_n, _s) __COPYRIGHT(_s)

#define __COPYRIGHT(_s) __SECTIONSTRING(.copyright, _s)

#define __KERNEL_RCSID(_n, _s) __RCSID(_s)

#define __KERNEL_SCCSID(_n, _s)

#define __KERNEL_COPYRIGHT(_n, _s) __COPYRIGHT(_s)

github-actions · 2024-02-02T14:25:46Z

ld.elf_so/NetBSD/cdefs_elf.h

+#define	__link_set_make_entry(set, sym)					\
+	static void const * const __link_set_##set##_sym_##sym		\
+	    __section("link_set_" #set) __used = (const void *)&sym
+#define	__link_set_make_entry2(set, sym, n)				\
+	static void const * const __link_set_##set##_sym_##sym##_##n	\
+	    __section("link_set_" #set) __used = (const void *)&sym[n]
+#else
+#define	__link_set_make_entry(set, sym)					\
+	extern void const * const __link_set_##set##_sym_##sym
+#define	__link_set_make_entry2(set, sym, n)				\
+	extern void const * const __link_set_##set##_sym_##sym##_##n


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define __link_set_make_entry(set, sym) \

static void const * const __link_set_##set##_sym_##sym \

__section("link_set_" #set) __used = (const void *)&sym

#define __link_set_make_entry2(set, sym, n) \

static void const * const __link_set_##set##_sym_##sym##_##n \

__section("link_set_" #set) __used = (const void *)&sym[n]

#else

#define __link_set_make_entry(set, sym) \

extern void const * const __link_set_##set##_sym_##sym

#define __link_set_make_entry2(set, sym, n) \

extern void const * const __link_set_##set##_sym_##sym##_##n

#define __link_set_make_entry(set, sym) \

static void const *const __link_set_##set##_sym_##sym \

__section("link_set_" #set) __used = (const void *)&sym

#define __link_set_make_entry2(set, sym, n) \

static void const *const __link_set_##set##_sym_##sym##_##n \

__section("link_set_" #set) __used = (const void *)&sym[n]

#else

#define __link_set_make_entry(set, sym) \

extern void const *const __link_set_##set##_sym_##sym

#define __link_set_make_entry2(set, sym, n) \

extern void const *const __link_set_##set##_sym_##sym##_##n

github-actions · 2024-08-16T13:19:46Z

Unit Test Results

7 958 tests ±0 7 434 ✅ ±0 40m 48s ⏱️ +27s
470 suites ±0 524 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 3e4be17. ± Comparison against base commit 8b2e050.

♻️ This comment has been updated with latest results.

Darchiv · 2025-03-27T13:57:30Z

ld.elf_so/expand.c

-		ep = (p = name) + len - 1;
-		break;
+		/* FIXME: Create POSIX header <sys/utsname.h> */
+		xwarn("expand of OSNAME, OSREL, PLATFORM is not yet supported");


You can use uname() after it is merged

Darchiv · 2025-03-27T14:53:06Z

ldconfig/ldconfig.c

+			}
+
+			char libphoenixAbsPath[PATH_MAX];
+			(void)sprintf(libphoenixAbsPath, "%s/%s", libsPath, dp->d_name); /* Must fit. */


It must fit (because ldconfig will fail) or it will always fit (it is guaranteed)? If it may not fit, then maybe use snprintf()

NetBSD Github commit hash: 6f77887749f85a214a1779de986ae4c095c32d60 JIRA: RTOS-664

JIRA: RTOS-664

Rename debug variable to avoid clash with phoenix syscall Change __progname to argv_progname. Remove sysctl usage for obtaining OSNAME, OSREL and PLATFORM. Fill in for missing or renamed functions and macros. Remove sysident.h as it inserted NetBSD info into the binary. Remove diaassert.c as it was for NetBSD's assert implementation. Remove compat.c as it was for compatibility with ancient NetBSD release, that Phoenix doesn't need to have. Adjust includes in arch/i386 JIRA: RTOS-664

file Those directives are NetBSD specific and not needed in Phoenix. JIRA: RTOS-664

JIRA: RTOS-664

Change how cleanup function is passed. Adjust to different stack layout. JIRA: RTOS-664

JIRA: RTOS-664

…er platforms JIRA: RTOS-664

JIRA: RTOS-664

badochov marked this pull request as draft January 30, 2024 15:25

github-actions bot reviewed Jan 30, 2024

View reviewed changes

badochov mentioned this pull request Jan 30, 2024

[RTLD] Dynamic linker phoenix-rtos/phoenix-rtos-project#990

Draft

13 tasks

badochov force-pushed the badochov/dynamic-linker branch from fe58e0b to 5c687c9 Compare January 30, 2024 16:04

github-actions bot reviewed Jan 30, 2024

View reviewed changes

badochov force-pushed the badochov/dynamic-linker branch from 5c687c9 to 109d4b3 Compare January 30, 2024 16:06

github-actions bot reviewed Jan 30, 2024

View reviewed changes

badochov force-pushed the badochov/dynamic-linker branch from 109d4b3 to fd807f3 Compare January 30, 2024 18:59

github-actions bot reviewed Jan 30, 2024

View reviewed changes

badochov force-pushed the badochov/dynamic-linker branch from fd807f3 to b0c06b2 Compare January 31, 2024 14:25

github-actions bot reviewed Jan 31, 2024

View reviewed changes

badochov force-pushed the badochov/dynamic-linker branch from b0c06b2 to 0b12e20 Compare February 1, 2024 13:16

github-actions bot reviewed Feb 1, 2024

View reviewed changes

badochov force-pushed the badochov/dynamic-linker branch from 0b12e20 to 3bafeb6 Compare February 2, 2024 13:00

github-actions bot reviewed Feb 2, 2024

View reviewed changes

badochov force-pushed the badochov/dynamic-linker branch from 3bafeb6 to c1173bd Compare February 2, 2024 14:25

github-actions bot reviewed Feb 2, 2024

View reviewed changes

badochov force-pushed the badochov/dynamic-linker branch 3 times, most recently from 866cad8 to eb74cd6 Compare August 7, 2024 12:21

badochov force-pushed the badochov/dynamic-linker branch from eb74cd6 to 621dbd5 Compare August 16, 2024 13:06

badochov force-pushed the badochov/dynamic-linker branch 3 times, most recently from 994f01a to 02e803e Compare August 21, 2024 11:14

badochov force-pushed the badochov/dynamic-linker branch 2 times, most recently from 4c7ff1f to ef78530 Compare August 27, 2024 18:00

badochov force-pushed the badochov/dynamic-linker branch 2 times, most recently from 75a0119 to 81da41a Compare September 17, 2024 11:22

badochov force-pushed the badochov/dynamic-linker branch 4 times, most recently from 7bdb54f to 5d97b7d Compare October 31, 2024 12:18

badochov force-pushed the badochov/dynamic-linker branch from 5d97b7d to 66aa847 Compare October 31, 2024 12:21

badochov force-pushed the badochov/dynamic-linker branch 2 times, most recently from 3b41f46 to 76d675c Compare December 5, 2024 12:46

badochov force-pushed the badochov/dynamic-linker branch from 76d675c to bac4b40 Compare March 26, 2025 18:02

Darchiv reviewed Mar 27, 2025

View reviewed changes

badochov and others added 17 commits March 27, 2025 23:54

ld.elf_so: Import ld.elf_so source code from NetBSD

498e173

NetBSD Github commit hash: 6f77887749f85a214a1779de986ae4c095c32d60 JIRA: RTOS-664

ld.elf_so: Import needed files from NetBSD

67a7843

NetBSD Github commit hash: 6f77887749f85a214a1779de986ae4c095c32d60 JIRA: RTOS-664

ld.elf_so: Change imports of headers migrated from NetBSD

56a63d7

JIRA: RTOS-664

ld.elf_so: Create Makefiles for Phoenix

11709be

JIRA: RTOS-664

ld.elf_so: Disable hardware dependent per library directives in config

82c55e3

file Those directives are NetBSD specific and not needed in Phoenix. JIRA: RTOS-664

ld.elf_so: Adjust mmap to Phoenix

de35180

JIRA: RTOS-664

ld.elf_so: Change locking to Phoenix mutexes

c945bf8

JIRA: RTOS-664

ld.elf_so: Adjust to reflect phoenix process startup ABI

7ad8284

Change how cleanup function is passed. Adjust to different stack layout. JIRA: RTOS-664

ld.elf_so: Add TLS support

0694399

JIRA: RTOS-664

ld.elf_so: Support dlfcn

f492c0d

JIRA: RTOS-664

ld.elf_so: Add stub library to access non-POSIX rtld api

0e78f30

JIRA: RTOS-664

ld.elf_so: Add RISC-V support

0a9c359

JIRA: RTOS-664

ld.elf_so: make _rtld_relocate_plt_object on RISC-V coherent with oth…

ac1d798

…er platforms JIRA: RTOS-664

ld.elf_so: add arm support

bb8422d

JIRA: RTOS-664

ld.elf_so: Add SPARC support

3ea6c81

ldconfig: create

3e4be17

JIRA: RTOS-664

badochov force-pushed the badochov/dynamic-linker branch from bac4b40 to 3e4be17 Compare March 27, 2025 22:54

		@@ -0,0 +1,12 @@
		# $NetBSD: Makefile.inc,v 1.3 2021/12/04 08:53:34 skrll Exp $

	# $NetBSD: Makefile.inc,v 1.3 2021/12/04 08:53:34 skrll Exp $
	#$NetBSD : Makefile.inc, v 1.3 2021 / 12 / 04 08 : 53 : 34 skrll Exp $

		@@ -0,0 +1,12 @@
		# $NetBSD: Makefile.inc,v 1.3 2021/12/04 08:53:34 skrll Exp $

		SRCS+= rtld_start.S mdreloc.c

	int
	_rtld_relocate_plt_objects(const Obj_Entry *obj)
	int _rtld_relocate_plt_objects(const Obj_Entry *obj)

		@@ -0,0 +1,11 @@
		# $NetBSD: Makefile.inc,v 1.12 2005/06/04 16:17:17 lukem Exp $

	# $NetBSD: Makefile.inc,v 1.12 2005/06/04 16:17:17 lukem Exp $
	#$NetBSD : Makefile.inc, v 1.12 2005 / 06 / 04 16 : 17 : 17 lukem Exp $

		@@ -0,0 +1,11 @@
		# $NetBSD: Makefile.inc,v 1.12 2005/06/04 16:17:17 lukem Exp $

		SRCS+= rtld_start.S alpha_reloc.c

	SRCS+= rtld_start.S alpha_reloc.c
	SRCS += rtld_start.S alpha_reloc.c

		# XXX Should not be in CPPFLAGS!
		CPPFLAGS+= -fpic -mno-fp-regs

	* Copyright 1996, 1997, 1998, 1999 John D. Polstra.
	* Copyright 1996, 1997, 1998, 1999 John D. Polstra.

	defobj->strtab + def->st_name, (void )where, (void *)new_value));
	defobj->strtab + def->st_name, (void )where, (void *)new_value));

	if (obj->pltgot[2] == (Elf_Addr) &_rtld_bind_start_old) {
	if (obj->pltgot[2] == (Elf_Addr)&_rtld_bind_start_old) {

		(void *)stubaddr, (long)where - (long)stubaddr,
		(long)delta));

	27 << 16 \| ((delta >> 16) & 0xffff);
	27 << 16 \| ((delta >> 16) & 0xffff);

	27 << 16 \| ((dhigh >> 16) & 0xffff);
	27 << 16 \| ((dhigh >> 16) & 0xffff);

	int
	_rtld_relocate_nonplt_objects(Obj_Entry *obj)
	int _rtld_relocate_nonplt_objects(Obj_Entry *obj)

-			}
+				}
+				tmp >>= 2;
+				*where = (*where & 0xff000000) | (tmp & 0x00ffffff);
+				rdbg(("PC24 %s in %s --> %p @ %p in %s",
+					obj->strtab + obj->symtab[ELF_R_SYM(rel->r_info)].st_name, obj->path, (void *)*where, where,
+					defobj->path));
+				break;
+			}

-		switch (ELF_R_TYPE(rel->r_info)) {
-		case R_TYPE(NONE):
-			break;
-#if 1 /* XXX should not occur */
-		case R_TYPE(PC24): {	/* word32 S - P + A */
-			Elf32_Sword addend;
-			/*
-			 * Extract addend and sign-extend if needed.
-			 */
-			addend = *where;
-			if (addend & 0x00800000)
-				addend |= 0xff000000;
-			tmp = (Elf_Addr)obj->relocbase + def->st_value
-			    - (Elf_Addr)where + (addend << 2);
-			if ((tmp & 0xfe000000) != 0xfe000000 &&
-			    (tmp & 0xfe000000) != 0) {
-				_rtld_error(
-				"%s: R_ARM_PC24 relocation @ %p to %s failed "
-				"(displacement %ld (%#lx) out of range)",
-				    obj->path, where,
-				    obj->strtab + obj->symtab[
-				        ELF_R_SYM(rel->r_info)].st_name,
-				    (long) tmp, (long) tmp);
-				return -1;
-			}
-			tmp >>= 2;
-			*where = (*where & 0xff000000) | (tmp & 0x00ffffff);
-			rdbg(("PC24 %s in %s --> %p @ %p in %s",
-			    obj->strtab + obj->symtab[ELF_R_SYM(rel->r_info)]
-			    .st_name, obj->path, (void *)*where, where,
-			    defobj->path));
-			break;
-		}
-#endif
-		case R_TYPE(ABS32):	/* word32 B + S + A */
-		case R_TYPE(GLOB_DAT):	/* word32 B + S */
-			if (__predict_true(RELOC_ALIGNED_P(where))) {
-				tmp = *where + (Elf_Addr)defobj->relocbase +
-				    def->st_value;
-				/* Set the Thumb bit, if needed.  */
-				if (ELF_ST_TYPE(def->st_info) == STT_ARM_TFUNC)
-				    tmp |= 1;
-				*where = tmp;
-			} else {
-				tmp = load_ptr(where) +
-				    (Elf_Addr)defobj->relocbase +
-				    def->st_value;
-				/* Set the Thumb bit, if needed.  */
-				if (ELF_ST_TYPE(def->st_info) == STT_ARM_TFUNC)
-				    tmp |= 1;
-				store_ptr(where, tmp);
-			}
-			rdbg(("ABS32/GLOB_DAT %s in %s --> %p @ %p in %s",
-			    obj->strtab + obj->symtab[ELF_R_SYM(rel->r_info)]
-			    .st_name, obj->path, (void *)tmp, where,
-			    defobj->path));
-			break;
-		case R_TYPE(IRELATIVE):
-			/* IFUNC relocations are handled in _rtld_call_ifunc */
-			if (obj->ifunc_remaining_nonplt == 0)
-				obj->ifunc_remaining_nonplt = obj->rellim - rel;
-			/* FALL-THROUGH */
-		case R_TYPE(RELATIVE):	/* word32 B + A */
-			if (__predict_true(RELOC_ALIGNED_P(where))) {
-				tmp = *where + (Elf_Addr)obj->relocbase;
-				*where = tmp;
-			} else {
-				tmp = load_ptr(where) +
-				    (Elf_Addr)obj->relocbase;
-				store_ptr(where, tmp);
-			}
-			rdbg(("RELATIVE in %s --> %p", obj->path,
-			    (void *)tmp));
-			break;
-		case R_TYPE(COPY):
-			/*
-			 * These are deferred until all other relocations have
-			 * been done.  All we do here is make sure that the
-			 * COPY relocation is not in a shared library.  They
-			 * are allowed only in executable files.
-			 */
-			if (obj->isdynamic) {
-				_rtld_error(
-			"%s: Unexpected R_COPY relocation in shared library",
-				    obj->path);
-				return -1;
-			}
-			rdbg(("COPY (avoid in main)"));
-			break;
-		case R_TYPE(TLS_DTPOFF32):
-			tmp = (Elf_Addr)(def->st_value);
-			if (__predict_true(RELOC_ALIGNED_P(where)))
-				*where = tmp;
-			else
-				store_ptr(where, tmp);
-			rdbg(("TLS_DTPOFF32 %s in %s --> %p",
-			    obj->strtab + obj->symtab[ELF_R_SYM(rel->r_info)]
-			    .st_name, obj->path, (void *)tmp));
-			break;
-		case R_TYPE(TLS_DTPMOD32):
-			tmp = (Elf_Addr)(defobj->tlsindex);
-			if (__predict_true(RELOC_ALIGNED_P(where)))
-				*where = tmp;
-			else
-				store_ptr(where, tmp);
-			rdbg(("TLS_DTPMOD32 %s in %s --> %p",
-			    obj->strtab + obj->symtab[ELF_R_SYM(rel->r_info)]
-			    .st_name, obj->path, (void *)tmp));
-			break;
-		case R_TYPE(TLS_TPOFF32):
-			if (!defobj->tls_static &&
-			    _rtld_tls_offset_allocate(__UNCONST(defobj)))
-				return -1;
-			if (__predict_true(RELOC_ALIGNED_P(where)))
-				tmp = *where;
-			else
-				tmp = load_ptr(where);
-			tmp += (Elf_Addr)def->st_value + defobj->tlsoffset + sizeof(struct tls_tcb);
-			if (__predict_true(RELOC_ALIGNED_P(where)))
-				*where = tmp;
-			else
-				store_ptr(where, tmp);
-			rdbg(("TLS_TPOFF32 %s in %s --> %p",
-			    obj->strtab + obj->symtab[ELF_R_SYM(rel->r_info)]
-			    .st_name, obj->path, (void *)tmp));
-			break;
-		default:
-			rdbg(("sym = %lu, type = %lu, offset = %p, "
-			    "contents = %p",
-			    (u_long)ELF_R_SYM(rel->r_info),
-			    (u_long)ELF_R_TYPE(rel->r_info),
-			    (void *)rel->r_offset, (void *)load_ptr(where)));
-			_rtld_error("%s: Unsupported relocation type %ld "
-			    "in non-PLT relocations",
-			    obj->path, (u_long) ELF_R_TYPE(rel->r_info));
-			return -1;
-		}

	int
	_rtld_relocate_plt_lazy(Obj_Entry *obj)
	int _rtld_relocate_plt_lazy(Obj_Entry *obj)

	for (rel = obj->pltrellim; rel-- > obj->pltrel; ) {
	for (rel = obj->pltrellim; rel-- > obj->pltrel;) {

[RTLD] Dynamic linker #214

Are you sure you want to change the base?

[RTLD] Dynamic linker #214

Conversation

badochov commented Jan 30, 2024

Description

Motivation and Context

Types of changes

How Has This Been Tested?

Checklist:

Special treatment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

Choose a reason for hiding this comment

github-actions bot Jan 30, 2024

		static SLIST_HEAD(hppa_plabel_head, _hppa_plabel) hppa_plabel_list
		= SLIST_HEAD_INITIALIZER(hppa_plabel_list);

	const Elf_Rela , Elf_Addr );
	const Elf_Rela , Elf_Addr );

	#define ELF32_MACHDEP_ID EM_386
	#define ELF32_MACHDEP_ID EM_386

		#define KERN_ELFSIZE 32
		#define ARCH_ELFSIZE 32 /* MD native binary size */

		#define __BITMAP_ZERO(__v) \
		(void)__builtin_memset((__v), 0, sizeof(*__v))

	#define __has_extension __has_feature /* Compat with pre-3.0 Clang */
	#define __has_extension __has_feature /* Compat with pre-3.0 Clang */

		#define ___STRING(x) __STRING(x)
		#define ___CONCAT(x,y) __CONCAT(x,y)

	#define __noasan __attribute__((no_sanitize("kernel-address", "address")))
	#define __noasan __attribute__((no_sanitize("kernel-address", "address")))

	#define __nocsan __attribute__((no_sanitize("thread")))
	#define __nocsan __attribute__((no_sanitize("thread")))

	#define __RENAME(x) ___RENAME(x)
	#define __RENAME(x) ___RENAME(x)