-
Notifications
You must be signed in to change notification settings - Fork 319
Fix the bug about the circular reference between jsCanvas and jsContext #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I read an document( a keynote of WWDC 2013, pdf http://devstreaming.apple.com/videos/wwdc/2013/615xax5xpcdns8jyhaiszkz2p/615/615.pdf?dl=1 , video http://devstreaming.apple.com/videos/wwdc/2013/615xax5xpcdns8jyhaiszkz2p/615/615-SD.mov?dl=1 ) about circular reference and garbage collection of JSBinging in iOS. The core of this pull request is :
A question : . |
|
the sytleObject in EJBingingCanvas may also use this way ? |
|
@phoboslab , Could you reproduce this issue ? |
|
I understand the issue, but I'm not very fond of the workaround using JS. I'll see if I can fix it in Obj-C land. |
|
Closing the PR. I'm leaving the related issue #398 open and will fix it eventually when I find the time. |
|
@phoboslab , Could you tell me How to fix it ? If you are busy, I could try to do |
|
This is very important for me, please. |
# By Dominic Szablewski (14) and finscn (1) # Via Dominic Szablewski * 'master' of github.com:phoboslab/Ejecta: Fix phoboslab#509 - make sure the final view render buffer is bound when resizing Fix phoboslab#514 - crash on failed IAP purchase Fix phoboslab#502 for WebGL Screen Canvas Fix phoboslab#498 - add 'target' property to touches Check if file exits before triggering image onload callback Cosmetics Resolve special paths for resources; close phoboslab#491 Fix phoboslab#502 - don't resize context when it doesn't yet have a framebuffer Silence warning for EJTexture return type Fix phoboslab#400 - cyclic reference of Canvas and CanvasContext Fix KeyInput delete; see phoboslab#484 Cosmetics Fix phoboslab#473 - Text Middle Baseline Calculation Update SRWebSocket.m Attempt to fix black screen on context creation; see phoboslab#462
fix #398
test - case :