Remove inline content

[joeldrapper]

I’m really sorry @Xanderwot. We changed our minds about this.

There was some discussion about this feature here https://github.com/orgs/phlex-ruby/discussions/761. We also discovered it added a 16% performance overhead.

I really appreciate your contributions and I’m sorry this one didn’t make it.

[Xanderwot]

👍
I totally understand what its pretty specific and probably rare used feature
Anyway just as discussion possibility:
What do you think about moving this feature under configuration option(like Phlex.config.enable_inline_tags)?
So it will allow to keep performance and make this feature optional.

Thanks for cooperation anyway

[Xanderwot]

You need to remove Phlex::Null definition also :)

[joeldrapper]

What do you think about moving this feature under configuration option(like Phlex.config.enable_inline_tags)?

The problem is any kind of check we do in those generated methods can have such a significant impact on the overall performance because they’re hit so many times.

I think there's a way you could patch it though so inline content still works.

As a little proof of concept, you should be able to do something like this

def div(content = nil, *, **)
  if content
    super(*, **) { plain(content) }
  else
    super
  end
end

You could iterate over Phlex::HTML.registered_elements and redefine each one.

[Xanderwot]

The problem is any kind of check we do in those generated methods can have such a significant impact on the overall performance because they’re hit so many times.

Idea was to move check at top level register_element so it will create original #{method_name} method if option disabled. So it will not decrease performance but will increate code lines because it will have two sets of metaprogrammed methods.
Anyway looks like patching is my only option, because rewriting fortitude legacy is to painful and time-consumable :)

[joeldrapper]

I guess we could break up the code generation into small parts that each can be patched. I’m trying to avoid over-complicating things though as that file is already pretty messy.