Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler improvements #202

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Compiler improvements #202

merged 2 commits into from
Oct 26, 2022

Conversation

joeldrapper
Copy link
Collaborator

@joeldrapper joeldrapper commented Sep 28, 2022 •
edited
Loading

Closes #19

@joeldrapper joeldrapper added the compiler Related to the compiler label Sep 28, 2022
@joeldrapper joeldrapper force-pushed the fcall-compiler branch 5 times, most recently from 29f0063 to e9dafcc Compare September 30, 2022 09:47
@joeldrapper joeldrapper force-pushed the fcall-compiler branch 3 times, most recently from 5aea6f3 to b708117 Compare October 25, 2022 02:22
@joeldrapper joeldrapper changed the title Initial function call compiler Compiler improvements Oct 25, 2022
@joeldrapper joeldrapper force-pushed the fcall-compiler branch 8 times, most recently from 59441df to 40bdbda Compare October 26, 2022 15:33
joeldrapper
joeldrapper commented Oct 26, 2022
View reviewed changes
lib/phlex/compiler/visitors/statements.rb Outdated

module Phlex::Compiler::Visitors
class Statements < Base
MUTATING_METHODS = [:raw, :whitespace, :comment, :yield_content, :text, :doctype]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yield_content might not mutate.

@joeldrapper joeldrapper marked this pull request as ready for review October 26, 2022 15:45
@joeldrapper joeldrapper merged commit e56826a into main Oct 26, 2022
@joeldrapper joeldrapper deleted the fcall-compiler branch October 26, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansakondo mansakondo mansakondo left review comments

Assignees
No one assigned
Labels
compiler Related to the compiler
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiled components
2 participants
@joeldrapper @mansakondo