Merge pull request #272 from joeldrapper/remove-redundant-slash-in-vo…

…id-elements Remove redundant slash in void elements
phlex-ruby · Oct 19, 2022 · e54bb5b · e54bb5b
2 parents 64dd283 + d49a194
commit e54bb5b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/phlex/html.rb b/lib/phlex/html.rb
@@ -164,9 +164,9 @@ def register_void_element(element, tag: element.name.tr("_", "-"))
 
         def #{element}(**attributes)
           if attributes.length > 0
-            @_target << "<#{tag}" << (Phlex::ATTRIBUTE_CACHE[attributes.hash] || _attributes(attributes)) << " />"
+            @_target << "<#{tag}" << (Phlex::ATTRIBUTE_CACHE[attributes.hash] || _attributes(attributes)) << ">"
           else
-            @_target << "<#{tag} />"
+            @_target << "<#{tag}>"
           end
 
           nil

diff --git a/test/phlex/view/tags.rb b/test/phlex/view/tags.rb
@@ -40,7 +40,7 @@
 			end
 
 			it "produces the correct output" do
-				expect(output).to be == %(<#{tag} class="class" id="id" disabled />)
+				expect(output).to be == %(<#{tag} class="class" id="id" disabled>)
 			end
 		end
 	end
-Original file line number
+Diff line change
@@ Expand Up / @@ -40,7 +40,7 @@ @@
     			end
     			it "produces the correct output" do
-    				expect(output).to be == %(<#{tag} class="class" id="id" disabled />)
+    				expect(output).to be == %(<#{tag} class="class" id="id" disabled>)
     			end
     		end
     	end
@@ Expand Down @@