Added null cases #217
Open
Added null cases #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmPatel123456
commented
Oct 30, 2024
| public static final String reverseWithStringConcat(String string) { | ||
|
|
||
| // Check if the input string is null or empty, and return an empty string if true | ||
| if (string == null || string.isEmpty()) { |
Author
There was a problem hiding this comment.
I added this if block so that if the string is null or if the string is empty the program can handle these cases without crashing or outputting an unexpected output.
OmPatel123456
commented
Oct 30, 2024
| public static final String reverseWithStringBuilder(String string) { | ||
|
|
||
| // Check if the input string is null or empty, and return an empty string if true | ||
| if (string == null || string.isEmpty()) { |
Author
There was a problem hiding this comment.
I added the the same if block here because this method also needs the same check as the previous regarding the null and empty string cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added null cases to string package. StringFunctions.java file needed the null cases in two methods.