Fix Grammar for XsltTask - be a real child of CopyTask and fix missing verbose attribute #1946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…optional selectors are allowed in fileset: Added
…ion that is reused in xslt task. => No xslt task is also in grammar extended from copy task
…plementation forced the to be present as pair
Old implementation forced both to be present
…ion that is reused in xslt task. => No xslt task is also in grammar extended from copy task
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1946 +/- ##
=========================================
Coverage 53.01% 53.01%
Complexity 9806 9806
=========================================
Files 495 495
Lines 24662 24662
=========================================
Hits 13075 13075
Misses 11587 11587 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation states
"Actually, XsltTask extends CopyTask, so you can use all the elements allowed there. "
Till now definition of xslttask in the grammar was an imperfect copy of copytask. For example the verbose attribute was missing from xslttask.
In order not only to fix but also prevent simmilar mistakes in future, I refactored copytask and extracted the definition into a separate define. This copy-definition is now used by copy and xslttask so xslttask can extend the definition without duplicated code and missing updates/errors.