Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raw_html treats the content of title tags as plain text #555

Merged
merged 2 commits into from
Mar 23, 2024
Merged

raw_html treats the content of title tags as plain text #555

merged 2 commits into from
Mar 23, 2024

Conversation

aymanosman
Copy link
Contributor

parse_document correctly treats the content of title tags as plain text. But raw_html does not. This PR fixes that.

@aymanosman
Copy link
Contributor Author

@philss I changed the test to avoid the differences between the parsers. I've ran mix test, mix test_fast_html and mix test_html5ever locally to verify all the tests pass.

@philss philss merged commit d1fd549 into philss:main Mar 23, 2024
9 checks passed
@philss
Copy link
Owner

philss commented Mar 23, 2024

@aymanosman thank you! And sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aymanosman @philss