Reduce number of function call on traverse #531
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today
traverse_with
is implemented in a way to make the pattern matching easier and split into multiple calls. This is causingtraverse_with
to be called three times for each element, one to get the top of the stack, one to get the first element of the list, and another to do the actual processing of the element.This PR updates traverse_with to use the stack directly, providing a small performance improvement and memory reduction
Finder benchmark