Add tap> support; add Babashka compatibility and remove ClojureScript dependency in Clojure #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for PR! I will release the new version of debux as soon as possible if it doesn't have any problems after investigating and testing. |
|
Fantastic, thank you, and also thanks again for Debux in general – it's been a godsend. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I understand this is a bit of an omnibus PR, but I'm still hoping I can get it merged like this without having to pick up the tweezers to try and pull it apart. :)
Babashka compatibility is based on your babashka branch and the changes were closely related to removing the ClojureScript dependency in Clojure-only projects (it can sometimes cause very unpleasant dependency conflicts).
This required Clojure 1.10.0+, so I went ahead and removed future-spec, which was also breaking Babashka. Looking at the State of Clojure survey and the Clojure versions commonly in use, this seems acceptable, I hope you concur.
Support for
tap>and the:simpleoption is needed for gnl/playback.I haven't added
tap>support todbgtyet.