ontology: removes RefCells from indexes. #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Both simpler and more functional! Guess I had not discovered the |
|
@phillord merged. Should we release a minor version to account for this fix? |
|
Wow, thank you for the super fast accommodation of our requirements, this is much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #126.
It is now possible to wrap
ArcIRIMappedOntologyusingOnceLock,Mutexetc.Additionally, this change removes some unsafe code that was needed to access the
BTreeMapthat was wrapped in aRefCell.I added
test_once_lock_ontology()to mimic the behavior showed by @KonradHoeffner in #126, which now passes.