Skip to content

Check whether json2ts exited without any errors before processing the generated ts file #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 29, 2022
Merged

Check whether json2ts exited without any errors before processing the generated ts file #14

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2230e8
When a generated ts file already exists but json2ts fails to write a …
qwyt Feb 8, 2022
efbbc58
Merge branch 'master' into improve_error_handling_when_json2ts_fails
phillipdupuis Aug 29, 2022
2815c05
Black formatting for script.py
phillipdupuis Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions pydantic2ts/cli/script.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,11 +210,17 @@ def generate_typescript_defs(

logger.info("Converting JSON schema to typescript definitions...")

os.system(f'{json2ts_cmd} -i {schema_file_path} -o {output} --bannerComment ""')
shutil.rmtree(schema_dir)
remove_master_model_from_output(output)
json2ts_exit_code = os.system(
f'{json2ts_cmd} -i {schema_file_path} -o {output} --bannerComment ""'
)

logger.info(f"Saved typescript definitions to {output}.")
if json2ts_exit_code == 0:
remove_master_model_from_output(output)
logger.info(f"Saved typescript definitions to {output}.")
else:
logger.error(f"{json2ts_cmd} failed with exit code {json2ts_exit_code}.")

shutil.rmtree(schema_dir)


def parse_cli_args(args: List[str] = None) -> argparse.Namespace:
Expand Down