Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent label mechanism for plotting cluster trajectories #142

Closed
niekdt opened this issue Nov 16, 2023 · 1 comment
Closed

Consistent label mechanism for plotting cluster trajectories #142

niekdt opened this issue Nov 16, 2023 · 1 comment
Assignees
@niekdt
Labels
enhancement New feature or request
Milestone
1.6.0

Comments

@niekdt
Copy link
Collaborator

niekdt commented Nov 16, 2023

As requested in #141, it would be useful if plotClusterTrajectories(data.frame) adds the cluster proportions into the cluster labels, similar to plotClusterTrajectories(lcModel).

Generalizing this further, the cluster label logic should be moved into the internal core function to ensure all plotClusterTrajectories methods use the same labeling mechanism.
@niekdt niekdt added the enhancement New feature or request label Nov 16, 2023
@niekdt niekdt self-assigned this Nov 24, 2023
niekdt added a commit that referenced this issue Jan 15, 2024
@niekdt
feat: implement make.clusterSizeLabels and make.clusterPropLabels for…
a512b33 
… easier plot label generation (#142)
niekdt added a commit that referenced this issue Jan 15, 2024
@niekdt
feat: clusterLabeler argument for plotClusterTrajectories (#142)
756e64f
@niekdt niekdt closed this as completed Jan 15, 2024
@niekdt
Copy link
Collaborator Author

niekdt commented Jan 15, 2024

The plotClusterTrajectories function now has a clusterLabeler argument that takes a function(clusterNames, cluserSizes) to output the respective labels. Default is the make.clusterPropLabels function.

@niekdt niekdt added this to the 1.6.0 milestone Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niekdt niekdt

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
1 participant
@niekdt