fix: update devcontainer template structure #1132
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the devcontainer template publishing workflow and standardizes template metadata across C++ and Rust flavors. The changes extract template publishing logic into a reusable workflow and simplify template identifiers and formatting.
Changes:
- Extracted template publishing logic into a new reusable workflow
wc-publish-templates.yml - Simplified template IDs from
cpp-template/rust-templatetocpp/rustand names fromamp-devcontainer-{lang}to the language name - Updated dependabot cooldown period from 5 to 7 days for both templates
Reviewed changes
Copilot reviewed 6 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/wc-publish-templates.yml |
New reusable workflow that centralizes template publishing logic |
.github/workflows/release-build.yml |
Refactored to call the new reusable workflow instead of duplicating steps |
templates/cpp/devcontainer-template.json |
Simplified template ID and name, removed publisher field, formatted arrays inline |
templates/rust/devcontainer-template.json |
Simplified template ID and name, removed publisher field, formatted arrays inline |
templates/cpp/.github/dependabot.yml |
Increased cooldown period from 5 to 7 days |
templates/rust/.github/dependabot.yml |
Increased cooldown period from 5 to 7 days |
Contributor
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 21 | 0 | 0 | 0.5s | |
| ✅ DOCKERFILE | hadolint | 3 | 0 | 0 | 0.68s | |
| ✅ GHERKIN | gherkin-lint | 6 | 0 | 0 | 2.31s | |
| ✅ JSON | npm-package-json-lint | yes | no | no | 0.3s | |
| ✅ JSON | prettier | 21 | 2 | 0 | 0 | 0.34s |
| ✅ JSON | v8r | 21 | 0 | 0 | 84.56s | |
| ✅ MARKDOWN | markdownlint | 12 | 0 | 0 | 0 | 0.82s |
| ✅ MARKDOWN | markdown-table-formatter | 12 | 0 | 0 | 0 | 0.2s |
| ✅ REPOSITORY | checkov | yes | no | no | 16.22s | |
| ✅ REPOSITORY | gitleaks | yes | no | no | 0.52s | |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.01s | |
| ✅ REPOSITORY | grype | yes | no | no | 28.68s | |
| ✅ REPOSITORY | secretlint | yes | no | no | 0.9s | |
| ✅ REPOSITORY | syft | yes | no | no | 1.85s | |
| ✅ REPOSITORY | trivy | yes | no | no | 5.49s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 0.23s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 2.24s | |
| lychee | 81 | 2 | 0 | 11.41s | ||
| ✅ YAML | prettier | 29 | 0 | 0 | 0 | 0.91s |
| ✅ YAML | v8r | 29 | 0 | 0 | 7.35s | |
| ✅ YAML | yamllint | 29 | 0 | 0 | 0.74s |
Detailed Issues
⚠️ SPELL / lychee - 2 errors
[IGNORED] docker://pandoc/extra:3.7.0@sha256:a703d335fa237f8fc3303329d87e2555dca5187930da38bfa9010fa4e690933a | Unsupported: Error creating request client: builder error for url (docker://pandoc/extra:3.7.0@sha256:a703d335fa237f8fc3303329d87e2555dca5187930da38bfa9010fa4e690933a)
[403] https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads | Network error: Forbidden
[ERROR] https://docs.sigstore.dev/cosign/verifying/verify/ | Network error: error sending request for url (https://docs.sigstore.dev/cosign/verifying/verify/) Maybe a certificate error?
[IGNORED] https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/philips-software/amp-devcontainer | Unsupported: Error creating request client: builder error for url (vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/philips-software/amp-devcontainer)
📝 Summary
---------------------
🔍 Total..........126
✅ Successful.....122
⏳ Timeouts.........0
🔀 Redirected.......0
👻 Excluded.........0
❓ Unknown..........0
🚫 Errors...........2
Errors in .github/TOOL_VERSION_ISSUE_TEMPLATE.md
[403] https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads | Network error: Forbidden
Errors in README.md
[ERROR] https://docs.sigstore.dev/cosign/verifying/verify/ | Network error: error sending request for url (https://docs.sigstore.dev/cosign/verifying/verify/) Maybe a certificate error?
See detailed reports in MegaLinter artifacts
Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)
- Documentation: Custom Flavors
- Command:
npx mega-linter-runner@9.3.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,DOCKERFILE_HADOLINT,GHERKIN_GHERKIN_LINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_GRYPE,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R
Contributor
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
Contributor
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
Contributor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Hey, I have created a Pull Request
Description of changes
This pull request refactors the workflow for publishing devcontainer templates and standardizes the organization and naming of template files. The main changes include moving and updating workflow configuration, renaming and updating template metadata, and making minor configuration tweaks.
Workflow refactoring and configuration:
publish-devcontainer-templatesjob in.github/workflows/release-build.ymlnow uses a reusable workflow (wc-publish-templates.yml), simplifying the main workflow file and centralizing the template publishing logic..github/workflows/wc-publish-templates.ymlthat defines the steps for publishing devcontainer templates, supporting both manual and workflow calls.Template file renaming and metadata standardization:
devcontainer-template.jsonfiles for both C++ and Rust templates to use simplified IDs and names (cppandrust), and formatted the JSON for consistency. [1] [2].github/dependabot.ymlfiles for both templates to new locations undertemplates/, and updated thecooldown.default-daysvalue from 5 to 7 for both C++ and Rust templates.✔️ Checklist