Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add metric to track GitHub app rate limit #4088

Merged
merged 9 commits into from
Aug 28, 2024

Conversation

npalm
Copy link
Member

@npalm npalm commented Aug 26, 2024

Description

This PR adds an optional metric to keep track of the remaining rate limit for teh GItHub app.

Notes

  • Refactored the metric configuration to align the metric configuration usages in all submodules. All changed are only impacting experimental features. Which means non breaking.
  • Refactored nameing gh-auth package, see separate commit.

@npalm npalm requested a review from stuartp44 August 26, 2024 13:25
Copy link
Collaborator

@stuartp44 stuartp44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments

docs/configuration.md Outdated Show resolved Hide resolved
examples/default/main.tf Show resolved Hide resolved
examples/default/main.tf Outdated Show resolved Hide resolved
examples/multi-runner/main.tf Show resolved Hide resolved
modules/runners/README.md Outdated Show resolved Hide resolved
modules/runners/variables.tf Outdated Show resolved Hide resolved
@npalm npalm requested a review from stuartp44 August 26, 2024 16:04
@npalm npalm force-pushed the npalm/feat/metric/rate-limit-gh branch from e60f6bd to f36b4f2 Compare August 27, 2024 06:19
stuartp44
stuartp44 previously approved these changes Aug 27, 2024
examples/default/main.tf Show resolved Hide resolved
@npalm npalm merged commit d7cdaed into main Aug 28, 2024
46 checks passed
@npalm npalm deleted the npalm/feat/metric/rate-limit-gh branch August 28, 2024 07:06
npalm pushed a commit that referenced this pull request Aug 28, 2024
🤖 I have created a release *beep* *boop*
---


##
[5.16.0](v5.15.4...v5.16.0)
(2024-08-28)


### Features

* Add metric to track GitHub app rate limit
([#4088](#4088))
([d7cdaed](d7cdaed))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants