Remove tensorflow-addons #266
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alization layer, because I do not need it for my purposes
DrumsnChocolate
commented
Oct 2, 2024
| @@ -251,7 +238,7 @@ def __init__(self, | |||
| self.output_slice_index = None # in case return_sequence=False | |||
| self.padding_same_and_time_dim_unknown = False # edge case if padding='same' and time_dim = None | |||
|
|
|||
| if self.use_batch_norm + self.use_layer_norm + self.use_weight_norm > 1: | |||
| if self.use_batch_norm + self.use_layer_norm > 1: | |||
There was a problem hiding this comment.
I thought to keep my changes minimal, but do we want to turn this into an or statement instead? since there's only two variables to check now
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tensorflow-addons has reached EOL, and to keep supporting newer versions of python, we need to drop the dependency. The simplest way to do that involves removing support for the weight normalization layer.