Bundle and test typescript declarations #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nataly87s
force-pushed
the
typescript-validation
branch
from
2ff360b to
fe9b04e
Compare
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 53 53
Branches 12 12
=====================================
Hits 53 53Continue to review full report at Codecov.
|
philipp-spiess
approved these changes
Oct 13, 2018
| export function Update<T>(state: T): UpdateAction<T>; | ||
|
|
||
| export function SideEffects<T>(sideEffect: T): SideEffectsAction<T>; | ||
| export function SideEffects<T>(sideEffect: SideEffect<T>): SideEffectsAction<T>; |
| @@ -0,0 +1,17 @@ | |||
| import { NoUpdate, Update, SideEffects, UpdateWithSideEffects } from 'react-recomponent'; | |||
There was a problem hiding this comment.
Just a side-node: Do you know if prettier supports TypeScript as well? If so we should probably run it for those files as well just for completeness 🙂
There was a problem hiding this comment.
It does.
You can also add husky and lint-staged to run prettier on the commit hook
There was a problem hiding this comment.
Awesome! Added support for it here: 0a46eef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #12