Skip to content

Prevent deepcopying of filter's parent #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 7, 2017

Conversation

rpkilby
Copy link
Collaborator

@rpkilby rpkilby commented Apr 25, 2017

It's unnecessary and costly to deepcopy the filter's parent and model. This should fix #171 as a side effect.

@rpkilby rpkilby added this to the v0.10.1 milestone Apr 25, 2017
@codecov-io
Copy link

codecov-io commented Apr 25, 2017

Codecov Report

Merging #172 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
+ Coverage   99.53%   99.53%   +<.01%     
==========================================
  Files           6        6              
  Lines         215      217       +2     
  Branches       42       42              
==========================================
+ Hits          214      216       +2     
  Partials        1        1
Impacted Files Coverage Δ
rest_framework_filters/filterset.py 99.14% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac68223...08d518d. Read the comment docs.

@philipn philipn merged commit 189e613 into philipn:master Jun 7, 2017
@rpkilby rpkilby deleted the exclude-request-interaction branch June 7, 2017 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deecopy error when using exclusion
3 participants