Skip to content

Fix request-based filtering #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 4, 2017
Merged

Conversation

rpkilby
Copy link
Collaborator

@rpkilby rpkilby commented Jan 29, 2017

This aims to fix #149.

  • Tests should demonstrate failure for the main filterset and related filtersets
  • The backend needs to initialize the filterset with the request
  • The related filtersets need to be initialized with the parent's filterset

@rpkilby rpkilby added this to the v1.0.0 milestone Jan 29, 2017
@codecov-io
Copy link

codecov-io commented Jan 29, 2017

Codecov Report

Merging #161 into master will increase coverage by 1.79%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
+ Coverage   97.73%   99.53%   +1.79%     
==========================================
  Files           6        6              
  Lines         221      215       -6     
  Branches       44       42       -2     
==========================================
- Hits          216      214       -2     
+ Misses          2        0       -2     
+ Partials        3        1       -2
Impacted Files Coverage Δ
rest_framework_filters/filterset.py 99.13% <100%> (ø) ⬆️
rest_framework_filters/backends.py 100% <100%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d99e6ed...72f2853. Read the comment docs.

@rpkilby rpkilby merged commit b5ccd8a into philipn:master Apr 4, 2017
@rpkilby rpkilby deleted the fix-request-filtering branch April 4, 2017 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request based filtering?
2 participants