restrict version of django-filters to <2.0 #147
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mayor version which may have breaking changes
Current coverage is 97.73% (diff: 100%)@@ master #147 diff @@
==========================================
Files 6 6
Lines 221 221
Methods 0 0
Messages 0 0
Branches 44 44
==========================================
Hits 216 216
Misses 2 2
Partials 3 3
|
|
Not convinced this is the correct thing to do. A breaking change to the public API does not necessarily mean that it breaks compatibility with another package. There's no reason to optimistically restrict this. If anything a similar patch should be applied to the 0.9.x branch where it's known that df 1.0 is not compatible. For now, I'd recommend version bounding django-filter/drf-filters in your requirements while a 1.0 compatible version is pushed out. Additionally, you may want to look at pip-tools. Edit: see #148 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a problem with a prior version of django-rest-framework-filters 0.8.0 which installed an incompatible version of django-filters (1.0.0).