Add metaclass inheritance test #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 96.84% (diff: 100%)@@ master #139 diff @@
==========================================
Files 6 6
Lines 222 222
Methods 0 0
Messages 0 0
Branches 45 45
==========================================
Hits 215 215
Misses 3 3
Partials 4 4
|
|
Hi @detonavomek, I've tried to add a test case for #132, but can't reproduce the failing behavior. Can you provide details? Edit: The original test case was not taking into account a related filterset. Calling |
rpkilby
force-pushed
the
fix-metaclass-inheritance
branch
from
d5b53be to
bc9b62b
Compare
rpkilby
force-pushed
the
fix-metaclass-inheritance
branch
from
75abf67 to
a57789f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #132, closes #133.