Declared filters overwritten by AllLookupsFilter #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpkilby
force-pushed
the
fix-declared-persistence
branch
from
097828a to
6372e7e
Compare
Current coverage is 91.21% (diff: 100%)@@ master #123 diff @@
==========================================
Files 7 7
Lines 303 296 -7
Methods 0 0
Messages 0 0
Branches 61 60 -1
==========================================
- Hits 274 270 -4
+ Misses 20 19 -1
+ Partials 9 7 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declared filters are overwritten by the current implementation of
AllLookupsFilter. This does not affectMeta.fieldsw/'__all__'This also uses
filters_for_modelto generate the filters forAllLookupsFilterandRelatedFilter.lookups. This removes the code duplication mentioned in #121.