TypeError: get_filter_name() takes 2 positional arguments but 3 were given

[danielhers]

Starting with django-filter 1.1.0 (released today), I get this error. With django-filter 1.0.4 it worked fine.

See carltongibson/django-filter#798, and the failing job here.

Seems like the problem is with this line, as the backtrace is:

File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/rest_framework_filters/filterset.py", line 19, in __new__
    new_class = super(FilterSetMetaclass, cls).__new__(cls, name, bases, attrs)
  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/django_filters/filterset.py", line 90, in __new__
    new_class.base_filters = new_class.get_filters()
  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/django_filters/filterset.py", line 320, in get_filters
    filter_name = cls.get_filter_name(field_name, lookup_expr)
TypeError: get_filter_name() takes 2 positional arguments but 3 were given

[george-silva]

same issue here.

does the 1.0.4 version works fine?

[danielhers]

Yes, a workaround is to pin django-filter to 1.0.4.

[george-silva]

Yep, it worked!

[rpkilby]

Hi all, this has been fixed on master. v0.10.2 should be inbound shortly, but if you want django-filter v1.1 compatibility now, you can install 373242f.

[rpkilby]

v0.10.2 is now on pypi

[george-silva]

@rpkilby I'll test this shortly and I'll get back!

Thanks!