Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor temporalscope #17

Merged
merged 8 commits into from
Sep 21, 2024
Merged

Refactor temporalscope #17

merged 8 commits into from
Sep 21, 2024

Conversation

philip-ndikum
Copy link
Owner

Pull Request

PR Type

  • 🐛 Bug Fix
  • ✨ Feature
  • 🚀 Performance Optimization
  • ♻️ Refactoring
  • 📚 Documentation Update
  • 🔧 Configuration Change
  • 🧪 Test Addition/Update
  • 🔨 CI/CD Change
  • Other (please describe):

Description

Refactored the SlidingWindowPartitioner class and the core utility files for consistent DataFrame handling across supported backends (Pandas, Modin, Polars). Also updated and renamed tutorial notebooks to reflect changes.

Related Issues

  • fixes #issue-number

Testing

Added/Updated Tests

  • Yes
  • No, and here's why:
  • I need help writing tests

How Has This Been Tested?

The refactored code has been tested with updated unit tests that reflect changes to the backend handling of DataFrames. Existing tests were run successfully.

  • Unit
  • Integration
  • Other:

Test Configuration

  • Python version: 3.9
  • Operating System: Ubuntu 20.04

Checklist

  • I have read the contributors guidelines and code of conduct
  • I have updated the documentation accordingly
  • I have added/updated tests as appropriate
  • I have updated the related issue(s) with new insights and changes
  • I have used a conventional commit type in my PR title
  • I have run pre-commit hooks and fixed any issues

Additional Notes

Additional documentation will be added in future updates. For now, this refactor focuses on ensuring consistent DataFrame handling.

philip-ndikum and others added 4 commits September 18, 2024 01:08
…n and core TimeFrame will utilize Universal Time Series model assumptions - assuming end-user will pre-filter or transform data without grouping from TemporalScope

Other time series ML/AI time series packages do not explicitly state modelling assumptions and nomenclature - API design allows for flexibility but enforces best-practice standards
…nting-errors-from-ruff,-including-docstring-format-and-magic-values---Resolved-issues-with-pre-commit-hooks-for-linting,-security,-and-style-checks---Ensured-codespell,-bandit,-mypy,-and-other-pre-commit-checks-pass-cleanly---Updated-and-cleaned-up-CI/CD-pipeline-to-ensure-smooth-code-integration): fix pre-commit linting errors and update ci/cd pipeline
…ocking-ci/cd-due-to-low-coverage.-set-project-threshold-to-50%-and-patch-threshold-to-10%,-making-it-highly-lenient-during-beta.): lower codecov thresholds for beta phase
@philip-ndikum philip-ndikum merged commit 7c36931 into main Sep 21, 2024
1 check passed
@kanenorman kanenorman deleted the refactor-temporalscope branch September 22, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant