-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor temporalscope #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n and core TimeFrame will utilize Universal Time Series model assumptions - assuming end-user will pre-filter or transform data without grouping from TemporalScope Other time series ML/AI time series packages do not explicitly state modelling assumptions and nomenclature - API design allows for flexibility but enforces best-practice standards
…istent dataframe handlin
…nting-errors-from-ruff,-including-docstring-format-and-magic-values---Resolved-issues-with-pre-commit-hooks-for-linting,-security,-and-style-checks---Ensured-codespell,-bandit,-mypy,-and-other-pre-commit-checks-pass-cleanly---Updated-and-cleaned-up-CI/CD-pipeline-to-ensure-smooth-code-integration): fix pre-commit linting errors and update ci/cd pipeline
…ocking-ci/cd-due-to-low-coverage.-set-project-threshold-to-50%-and-patch-threshold-to-10%,-making-it-highly-lenient-during-beta.): lower codecov thresholds for beta phase
philip-ndikum
force-pushed
the
refactor-temporalscope
branch
from
September 21, 2024 03:05
5b46e19
to
84a1f40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
PR Type
Description
Refactored the SlidingWindowPartitioner class and the core utility files for consistent DataFrame handling across supported backends (Pandas, Modin, Polars). Also updated and renamed tutorial notebooks to reflect changes.
Related Issues
Testing
Added/Updated Tests
How Has This Been Tested?
The refactored code has been tested with updated unit tests that reflect changes to the backend handling of DataFrames. Existing tests were run successfully.
Test Configuration
Checklist
Additional Notes
Additional documentation will be added in future updates. For now, this refactor focuses on ensuring consistent DataFrame handling.