Skip to content

Conversation

@ademuri
Copy link
Contributor

@ademuri ademuri commented Jan 3, 2026

This uses Github Actions to run deno fmt --check and then ./make.js test. It also configures deno fmt to ignore the icon SVGs, and changes the DOM tests to launch Puppeteer with --no-sandbox.

@philc
Copy link
Owner

philc commented Jan 5, 2026

Thanks for the PR. What was your motivation for adding the workflow?

I'm concerned maintaining the configuration adds more moving parts than it's worth -- I haven't experienced much pain resulting from broken tests or unformatted code in PRs for this project.

Why is make.js reformatted in this PR? The version in master looks correctly formatted.

Great idea to exclude svgs from deno's fmt check.

This runs `deno fmt --check` and then `./make.js test`. It also
configures `deno fmt` to ignore the icon SVGs, and changes the DOM tests
to launch Puppeteer with `--no-sandbox`.
@ademuri
Copy link
Contributor Author

ademuri commented Jan 6, 2026

I'm not sure why make.js was re-formatted - I reverted that change.

I read your contributing guide, and thought that since reviewer time is relatively scarce, this would be helpful. This also makes contributing easier, as for small changes authors don't necessarily need to install the build environment locally to get test results. The maintenance burden for this config is low, and I'm happy to own fixing any breakages. If anything breaks, it's easy to ignore or disable.

Checking that formatting is applied at each commit helps keep diffs/blame clean, rather than requiring specific formatting commits. If you're amenable, I can submit a pull request to add a commit hook to run deno fmt on commit, so that formatting is automatically applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants