use upper-case key names to represent shiftKey in <([acm]-)?.*> key mappings #2390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another solution to #2388, and allows users to make such key mappings:
The added logic is that if a
keyChar
(background_scripts/commands.coffee#L75) has only upper-case chars, then it meansShift
should be pressed.This does not influence most old mappings like
<Left>
, but will treat<f1>
and<F1>
differently.