Skip to content

Esc to exit insert mode in embeds. #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

smblott-github
Copy link
Collaborator

Currently, when an embed has the focus, Esc doesn't get Vimium out of insert mode. This fixes that.

This is the right thing to do in the most common use cases, and for most users. Unfortunately, it could cripple some flash-based sites and games.

Proposal:

  • Introduce this into post-1.46 on an experimental basis.

We (I, actually) need feedback as to whether this is the right thing to do.

Here's a (rather unfortunate) test page.

See also #1211 and #1194.

This reverts commit a277fa6.

Conflicts:
	content_scripts/vimium_frontend.coffee
@mrmr1993
Copy link
Contributor

This doesn't currently work properly. esc enters normal mode, but doesn't blur the flash element. The correct implementation can be seen at commit e507047.

@smblott-github
Copy link
Collaborator Author

Closing in favour or #1377.

@smblott-github smblott-github deleted the blur-on-escape branch May 15, 2015 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants