Esc to exit insert mode in embeds. #1371
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when an
embed
has the focus,Esc
doesn't get Vimium out of insert mode. This fixes that.This is the right thing to do in the most common use cases, and for most users. Unfortunately, it could cripple some flash-based sites and games.
Proposal:
post-1.46
on an experimental basis.We (I, actually) need feedback as to whether this is the right thing to do.
Here's a (rather unfortunate) test page.
See also #1211 and #1194.