Skip to content

Add command for downloading links #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add command for downloading links #1131

wants to merge 1 commit into from

Conversation

mrmr1993
Copy link
Contributor

Fixes #331

mrmr1993 added a commit to mrmr1993/vimium that referenced this pull request Oct 13, 2014
@mrmr1993
Merge pull request philc#1131 from mrmr1993/downloadLinks
4313433 
Conflicts:
	CREDITS
	background_scripts/commands.coffee
	background_scripts/main.coffee
	content_scripts/link_hints.coffee
	manifest.json
@mrmr1993 mrmr1993 mentioned this pull request Oct 13, 2014
Closed
@mrmr1993
Copy link
Contributor Author

Rebased.

@smblott-github
Copy link
Collaborator

Thanks, @mrmr1993. But II think we have this covered now in #784.

I'll close this for now. Please reopen it if you still see an issue.

@mrmr1993
Copy link
Contributor Author

This forces the Save As dialog, while the alternative just downloads the files straight to the Downloads folder without offering to change the filename/directory (at least for me).

@mrmr1993
Copy link
Contributor Author

@smblott-github I want to reopen this (since the Save As feature is different to the Save feature from #784, see my previous comment), but I'm not able. Could you re-open it from your end?

@smblott-github
Copy link
Collaborator

I'll reopen it for discussion. But it's not great to have a proliferation of similar commands.

@smblott-github
Copy link
Collaborator

Re-closing due to a lack of discussion.

@mrmr1993 mrmr1993 deleted the downloadLinks branch November 13, 2017 23:12
@mrmr1993 mrmr1993 mentioned this pull request Nov 13, 2017
Open
@mrmr1993 mrmr1993 restored the downloadLinks branch November 16, 2017 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support "Save Link As..." with keyboard shortcut
2 participants
@mrmr1993 @smblott-github