-
Notifications
You must be signed in to change notification settings - Fork 1
2 tasks: Telnet server & Authentication server. #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
philard
wants to merge
41
commits into
before_week4-telnet_chat_server
Choose a base branch
from
master
base: before_week4-telnet_chat_server
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…" and "show". - Bug if the user crossed out the "prefs" window. - Todo unit tests.
Todo: - Unit tests - handlerChatMessage
- done "handleChatMessage". - done "no" detection. todo: make code look nicer todo: unit testing
git rm --cached .idea -r
Soo I'm taking my authServer work from another repo.
… in the browser (non amd/script tag loaded) AND in the npm test (ES6 babelified module loaded). For now on all my tests with conform to this style.
* post user_page now edits just one permission noun.
* Own permissions editable from a table. * You can add new permission on the user_page now. * Permission error messages displayed on user_page. * Separate handlers for rejected permissions for GET and POST in user_page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains two tasks, the first in "week4", then seconds in "authServer".
Telnet server
The server is functional. It will punish you if you type " no". It will ask for your name, quest and favorite color. It will send you a message when a new user joins and when users send a message. The new messages will be inserted above the user's half typed message in the telnet client. Connect with "telnet localhost:7171". There is a unit test for the handler module.
Auth server
Working example of express-authorization. Authorization rules belong to users and each rule consists of one or more nouns followed by on or more verbs based on the "Apache Shiro" functionality. Authentication provided by express-session. Run npm install, then node express-authorization.js.
Any comments/improvements on the back end structure would be welcome.