-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix notification LED on jasmine #49
Conversation
The HAL behaves in mysterious ways and requires this blink file to be writable. Also sync permissions with stock ROM just in case.
You tested that modified rw-system.sh right? |
I patched my current rw-system instead of building a new system, but yes, the files get successfully modified. There still seems to be an issue where the LED is randomly initialized to be "on" on android start. I will edit this once I find a final fix. |
Feedback for wayne: |
I had my tester give this a shot on the AEX Pie GSI (arm64). It doesn't seem to work. His |
Some more feedback: It breaks itself when plugged into power. However, If one reboots twice (with the cable unplugged), the issue is resolved. However, charging the device will no longer trigger the LED. So it seems that there's most likely an issue with the LED receiving events..? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This device tree file includes all the proper commands necessary for this to work. Please update it based on this:
on boot
# Notification LED
chown system system /sys/class/leds/red/blink
chown system system /sys/class/leds/red/brightness
chown system system /sys/class/leds/red/duty_pcts
chown system system /sys/class/leds/red/pause_hi
chown system system /sys/class/leds/red/pause_lo
chown system system /sys/class/leds/red/ramp_step_ms
chown system system /sys/class/leds/red/start_idx
chmod 660 /sys/class/leds/red/duty_pcts
chmod 660 /sys/class/leds/red/pause_hi
chmod 660 /sys/class/leds/red/pause_lo
chmod 660 /sys/class/leds/red/ramp_step_ms
chmod 660 /sys/class/leds/red/start_idx
@p4block this fixes on Oreo vendor, Pie vendor or both? |
@tytydraco Yes. I was the tester. Btw are there any updates on this issue? @phhusson |
Please close this thread. A proper fix was merged into the main branch. |
The HAL behaves in mysterious ways and requires this blink file to be writable. Also sync permissions with stock ROM just in case.